Bug 1945443: Use DeploymentAvailable instead of custom test for CSV status. #68
Conversation
CSVs can transition to Failed (reason ComponentUnhealthy) if a single pod managed by one of its deployments is deleted. This commit changes the deployment availability test from a comparison between .status.availableReplicas and .status.updatedReplicas to a check that passes unless the deployment's Available condition exists and is False. Upstream-commit: 929fa8b8ce0039240d0b097d5237a62689d269b5 Upstream-repository: operator-lifecycle-manager
openshift-ci-robot
added
the
bugzilla/severity-high
|
@benluddy: This pull request references Bugzilla bug 1945443, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1945443 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
NO-ISSUE: Remove ncdc from OWNERS #68
CSVs can transition to Failed (reason ComponentUnhealthy) if a single
pod managed by one of its deployments is deleted. This commit changes
the deployment availability test from a comparison between
.status.availableReplicas and .status.updatedReplicas to a check that
passes unless the deployment's Available condition exists and is
False.