OCPBUGS-29083: * olm,catalog: only validate the resources we label

[stevekuznetsov]

• *: don't duplicate owner references

• olm,catalog: only validate the resources we label

Each controller can see (and, therefore, can label) a separate set of GVRs. When we start up, detecting if any OLM-related resource needs labelling means that one controller may start, detect a need for labelling a resource it cannot itself label, detect that it's labelled everything it can, and restart. If the other operator is stuck for whatever reason, this leads the first controller to enter CrashLoopBackOff and break OCP upgrade.

• catalog: prune duplicate OwnerReferences on Services

---

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1e0324c128d3095e2f1a66e5c27cfa617eeea876

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-28744, which is invalid:

• expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.16.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-28744 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• *: don't duplicate owner references

• olm,catalog: only validate the resources we label

Each controller can see (and, therefore, can label) a separate set of GVRs. When we start up, detecting if any OLM-related resource needs labelling means that one controller may start, detect a need for labelling a resource it cannot itself label, detect that it's labelled everything it can, and restart. If the other operator is stuck for whatever reason, this leads the first controller to enter CrashLoopBackOff and break OCP upgrade.

• catalog: prune duplicate OwnerReferences on Services

---

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1e0324c128d3095e2f1a66e5c27cfa617eeea876

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stevekuznetsov]

/jira backport OCPBUGS-28744

[stevekuznetsov]

/jira cherrypick OCPBUGS-28744

[openshift-ci-robot]

@stevekuznetsov: Jira Issue OCPBUGS-28744 has been cloned as Jira Issue OCPBUGS-29083. Will retitle bug to link to clone.
/retitle OCPBUGS-29083: OCPBUGS-28744: * olm,catalog: only validate the resources we label

In response to this:

/jira cherrypick OCPBUGS-28744

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-29083, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-28744 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-28744 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• *: don't duplicate owner references

• olm,catalog: only validate the resources we label

Each controller can see (and, therefore, can label) a separate set of GVRs. When we start up, detecting if any OLM-related resource needs labelling means that one controller may start, detect a need for labelling a resource it cannot itself label, detect that it's labelled everything it can, and restart. If the other operator is stuck for whatever reason, this leads the first controller to enter CrashLoopBackOff and break OCP upgrade.

• catalog: prune duplicate OwnerReferences on Services

---

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1e0324c128d3095e2f1a66e5c27cfa617eeea876

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kevinrizza]

/approve
/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jianzhangbjz]

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-29083
/lgtm
/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-29083, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-28744 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-28744 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• *: don't duplicate owner references

• olm,catalog: only validate the resources we label

Each controller can see (and, therefore, can label) a separate set of GVRs. When we start up, detecting if any OLM-related resource needs labelling means that one controller may start, detect a need for labelling a resource it cannot itself label, detect that it's labelled everything it can, and restart. If the other operator is stuck for whatever reason, this leads the first controller to enter CrashLoopBackOff and break OCP upgrade.

• catalog: prune duplicate OwnerReferences on Services

---

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1e0324c128d3095e2f1a66e5c27cfa617eeea876

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4ffebf7 and 2 for PR HEAD fc89389 in total

[kevinrizza]

Merging manually because of CI flakes

[openshift-ci-robot]

@stevekuznetsov: Jira Issue OCPBUGS-29083: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#683

Jira Issue OCPBUGS-29083 has been moved to the MODIFIED state.

In response to this:

• *: don't duplicate owner references

• olm,catalog: only validate the resources we label

Each controller can see (and, therefore, can label) a separate set of GVRs. When we start up, detecting if any OLM-related resource needs labelling means that one controller may start, detect a need for labelling a resource it cannot itself label, detect that it's labelled everything it can, and restart. If the other operator is stuck for whatever reason, this leads the first controller to enter CrashLoopBackOff and break OCP upgrade.

• catalog: prune duplicate OwnerReferences on Services

---

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1e0324c128d3095e2f1a66e5c27cfa617eeea876

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@stevekuznetsov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm	fc89389	link	unknown	/test e2e-gcp-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202402071837.p0.g6a9ced9.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.