Skip to content

OCPBUGS-29553: Apply hypershift cluster-profile for ibm-cloud-managed #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openshift-art-build-bot

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29553, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-art-build-bot
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr
Copy link
Contributor

If other files need to be updated to support this, please let me know.

@kevinrizza
Copy link
Member

@ashwindasr I think we wouldn't be able to accept this pull request as is. This repository is downstream of https://github.com/operator-framework/operator-lifecycle-manager, and the kube manifests get generated from the templates in that repo. You would need to either submit a pull request upstream to include this annotation upstream (which I think would be unlikely to be accepted in that project) or you would need to update the manifest generation scripts to generate these manifests in a carry patch.

There's something similar in one of our manifest generation scripts here: https://github.com/openshift/operator-framework-olm/blob/master/scripts/generate_crds_manifests.sh#L70

@ashwindasr
Copy link
Contributor

@kevinrizza thank you. Guess I'd have to go with option 2 then.

@ashwindasr
Copy link
Contributor

/close

In favor of #697

Thanks @ankitathomas

@openshift-ci openshift-ci bot closed this Feb 15, 2024
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@ashwindasr: Closed this PR.

In response to this:

/close

In favor of #697

Thanks @ankitathomas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29553. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@openshift-art-build-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify efe1f2a link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants