-
Notifications
You must be signed in to change notification settings - Fork 71
OCPBUGS-29553: Apply hypershift cluster-profile for ibm-cloud-managed #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29553: Apply hypershift cluster-profile for ibm-cloud-managed #696
Conversation
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29553, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-art-build-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If other files need to be updated to support this, please let me know. |
@ashwindasr I think we wouldn't be able to accept this pull request as is. This repository is downstream of https://github.com/operator-framework/operator-lifecycle-manager, and the kube manifests get generated from the templates in that repo. You would need to either submit a pull request upstream to include this annotation upstream (which I think would be unlikely to be accepted in that project) or you would need to update the manifest generation scripts to generate these manifests in a carry patch. There's something similar in one of our manifest generation scripts here: https://github.com/openshift/operator-framework-olm/blob/master/scripts/generate_crds_manifests.sh#L70 |
@kevinrizza thank you. Guess I'd have to go with option 2 then. |
/close In favor of #697 Thanks @ankitathomas |
@ashwindasr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29553. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-art-build-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed
, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershift
addition will allow Hypershift to express different profile choices than ROKS