Skip to content

OCPBUGS-32311: [release-4.15]: Update if AlreadyExists #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2024
Merged

OCPBUGS-32311: [release-4.15]: Update if AlreadyExists #736

merged 2 commits into from
Apr 17, 2024

Conversation

kevinrizza
Copy link
Member

Upstream-repository: operator-lifecycle-manager
Upstream-commit: a7b6658a0eaf161433fbda9bb4fa66adb0862aaa

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

dtfranz added 2 commits April 16, 2024 11:41
@dtfranz @kevinrizza
RoleBinding SSA (#3190)
1dcc7cf 
Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels.

Signed-off-by: Daniel Franz <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c
@dtfranz @kevinrizza
Update if AlreadyExists (#3202)
c077b3d 
Adds code to the client calls for Create to run an Update if the object already exists. This allows us to bypass issues where the object was not found in cache but already exists in the cluster.

Signed-off-by: Daniel Franz <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a7b6658a0eaf161433fbda9bb4fa66adb0862aaa
@kevinrizza kevinrizza changed the title Alreadyexists fix 4.15 OCPBUGS-32311: [release-4.15]: Alreadyexists fix 4.15 Apr 16, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2024
@openshift-ci-robot
Copy link

@kevinrizza: This pull request references Jira Issue OCPBUGS-32311, which is invalid:

  • expected Jira Issue OCPBUGS-32311 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Upstream-repository: operator-lifecycle-manager
Upstream-commit: a7b6658a0eaf161433fbda9bb4fa66adb0862aaa

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kevinrizza kevinrizza changed the title OCPBUGS-32311: [release-4.15]: Alreadyexists fix 4.15 OCPBUGS-32311: [release-4.15]: Update if AlreadyExists Apr 16, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@kevinrizza
Copy link
Member Author

/bugzilla refresh

@kevinrizza
Copy link
Member Author

/retest

@kuiwang02
Copy link

/hold

it for pre-testing.
thanks

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@kevinrizza: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kuiwang02
Copy link

/unhold

pre-verify pass

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@kuiwang02
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Apr 17, 2024
@openshift-ci-robot
Copy link

@kevinrizza: This pull request references Jira Issue OCPBUGS-32311, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Upstream-repository: operator-lifecycle-manager
Upstream-commit: a7b6658a0eaf161433fbda9bb4fa66adb0862aaa

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kevinrizza
Copy link
Member Author

/bugzilla refresh

@kevinrizza
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 17, 2024
@kevinrizza
Copy link
Member Author

/bugzilla refresh

m1kola
m1kola approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 17, 2024
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-32311, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-31479 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31479 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from kuiwang02 April 17, 2024 12:03
@openshift-merge-bot openshift-merge-bot bot merged commit f6374fb into openshift:release-4.15 Apr 17, 2024
@openshift-ci-robot
Copy link

@kevinrizza: Jira Issue OCPBUGS-32311: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32311 has been moved to the MODIFIED state.

In response to this:

Upstream-repository: operator-lifecycle-manager
Upstream-commit: a7b6658a0eaf161433fbda9bb4fa66adb0862aaa

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202404171237.p0.gf6374fb.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

@wking wking mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1kola m1kola m1kola approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@joelanford joelanford Awaiting requested review from joelanford

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

Assignees

@bandrade bandrade

@m1kola m1kola

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.