Fix generate CRD script by using copy #748
Conversation
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-olm |
|
/retest |
1 similar comment
|
/retest |
|
New changes are detected. LGTM label has been removed. |
| ENV GOPATH /go | ||
| ENV PATH $GOPATH/bin:/usr/local/go/bin:$PATH | ||
| WORKDIR /src | ||
| COPY . . | ||
| # Install golang 1.22.2 |
There was a problem hiding this comment.
ART is generating a new registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.22-openshift-4.17 we can use here to coordinate with new go1.22 toolchain.
openshift-ci
bot
added
the
do-not-merge/hold
|
OK, not sure why I'm getting manifest changes, now? It wasn't the case earlier? And also operator-registry is now having issues with the stable hash? |
|
/test images |
|
/test periodics-images |
Using a symlink to point inside the staging directories seems to confuse
newer versions of sigs.k8s.io/controller-tools.
Specifically, the set up of a temporary directory for controller-gen
uses a symlink into staging/api, which confuses _something_ in golang
to use ${ROOT}/staging/api/go.mod rather than ${ROOT}/go.mod, causing
it to return errors that indicate go.mod inconsistencies with
vendor/modules.txt. This would normally be fixable via the `go mod`
commands, but looking at the wrong go.mod is not a normal situation.
Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Todd Short <[email protected]>
|
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* render: support rendering FBC from bundle and packagemanifest directories In order to generate expected olm.bundles, this commit also adds a new --image-ref-template flag to the `render` subcommand, which callers can use to generate image references from source data based on package name, bundle name, and bundle version. Signed-off-by: Joe Lanford <[email protected]> * make --image-ref-template alpha (and include simple framework for alpha flags and usage) Signed-off-by: Joe Lanford <[email protected]> --------- Signed-off-by: Joe Lanford <[email protected]> Upstream-repository: operator-registry Upstream-commit: a21f962e4b609f61257d4e78745e26c298ac53d4
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Done as part of the latest, large downstream. |
Using a symlink to point inside the staging directories seems to confuse newer versions of sigs.k8s.io/controller-tools.
Specifically, the set up of a temporary directory for controller-gen uses a symlink into staging/api, which confuses something in golang to use ${ROOT}/staging/api/go.mod rather than ${ROOT}/go.mod, causing it to return errors that indicate go.mod inconsistencies with vendor/modules.txt. This would normally be fixable via the
go modcommands, but looking at the wrong go.mod is not a normal situation.