Skip to content

OCPBUGS-31985,OCPBUGS-31986,OCPBUGS-32856: bump go-jose to v2.6.3 #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

everettraven
Copy link
Contributor

  • Forks go-jose/go-jose v2.6.3 to a subdirectory
  • Replaces gopkg.in/square/go-jose.v2 with ./forks/go-jose
  • go mod tidy
  • go mod vendor

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2024
@openshift-ci-robot
Copy link

@everettraven: This pull request references Jira Issue OCPBUGS-32856, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-32856 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Forks go-jose/go-jose v2.6.3 to a subdirectory
  • Replaces gopkg.in/square/go-jose.v2 with ./forks/go-jose
  • go mod tidy
  • go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from anik120 and joelanford June 12, 2024 19:09
@everettraven
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@everettraven: This pull request references Jira Issue OCPBUGS-32856, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: everettraven <[email protected]>
Signed-off-by: everettraven <[email protected]>
Signed-off-by: everettraven <[email protected]>
@joelanford
Copy link
Member

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 12, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@everettraven
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@emmajiafan
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 13, 2024
@everettraven
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@everettraven: This pull request references Jira Issue OCPBUGS-32856, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 13, 2024
@openshift-ci-robot
Copy link

@everettraven: This pull request references Jira Issue OCPBUGS-32856, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-33356 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-33356 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d8cfe86 into openshift:release-4.13 Jun 13, 2024
13 checks passed
@openshift-ci-robot
Copy link

@everettraven: Jira Issue OCPBUGS-32856: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32856 has been moved to the MODIFIED state.

In response to this:

  • Forks go-jose/go-jose v2.6.3 to a subdirectory
  • Replaces gopkg.in/square/go-jose.v2 with ./forks/go-jose
  • go mod tidy
  • go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theishshah
Copy link
Contributor

/retitle OCPBUGS-31985,OCPBUGS-31986,OCPBUGS-32856: bump go-jose to v2.6.3

@openshift-ci openshift-ci bot changed the title OCPBUGS-32856: bump go-jose to v2.6.3 OCPBUGS-31985,OCPBUGS-31986,OCPBUGS-32856: bump go-jose to v2.6.3 Jun 26, 2024
@openshift-ci-robot
Copy link

@everettraven: Jira Issue OCPBUGS-31985: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31985 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-31986: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31986 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-32856 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

  • Forks go-jose/go-jose v2.6.3 to a subdirectory
  • Replaces gopkg.in/square/go-jose.v2 with ./forks/go-jose
  • go mod tidy
  • go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants