Skip to content

OCPBUGS-25341,OCPBUGS-34173: [Manual] Synchronize From Upstream Repositories #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ankitathomas
Copy link
Contributor

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2024-06-20 11:19:53 operator-framework/operator-lifecycle-manager@908da0c Ankita Thomas [OCPBUGS-25341]: perform operator apiService certificate validity checks directly (#3217)
2024-06-20 10:00:07 operator-framework/operator-lifecycle-manager@20a3cbc Ankita Thomas [OCPBUGS-34173]: fix sorting unpack jobs (#3299)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

* fix sorting unpack jobs

Signed-off-by: Ankita Thomas <[email protected]>

* Add test cases to reproduce panic

Signed-off-by: Catherine Chan-Tse <[email protected]>

* handle nil jobs while sorting unpack jobs

Signed-off-by: Ankita Thomas <[email protected]>

---------

Signed-off-by: Ankita Thomas <[email protected]>
Signed-off-by: Catherine Chan-Tse <[email protected]>
Co-authored-by: Catherine Chan-Tse <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 20a3cbcde1f46ed7f4d56042ccc8b5d962e4d1b8
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request explicitly references no jira issue.

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2024-06-20 11:19:53 operator-framework/operator-lifecycle-manager@908da0c Ankita Thomas [OCPBUGS-25341]: perform operator apiService certificate validity checks directly (#3217)
2024-06-20 10:00:07 operator-framework/operator-lifecycle-manager@20a3cbc Ankita Thomas [OCPBUGS-34173]: fix sorting unpack jobs (#3299)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ankitathomas ankitathomas changed the title NO-ISSUE: [Manual] Synchronize From Upstream Repositories OCPBUGS-25341,OCPBUGS-34173: [Manual] Synchronize From Upstream Repositories Jun 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Jun 24, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-25341, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-34173, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2024-06-20 11:19:53 operator-framework/operator-lifecycle-manager@908da0c Ankita Thomas [OCPBUGS-25341]: perform operator apiService certificate validity checks directly (#3217)
2024-06-20 10:00:07 operator-framework/operator-lifecycle-manager@20a3cbc Ankita Thomas [OCPBUGS-34173]: fix sorting unpack jobs (#3299)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 24, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@ankitathomas
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 24, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-25341, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references Jira Issue OCPBUGS-34173, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…cks directly (#3217)

* perform operator apiService certificate validity checks directly

Signed-off-by: Ankita Thomas <[email protected]>

* use sets to track certs to install, revert to checking for installPlan
timeouts after API availability checks, add service FQDN to list of
hostnames.

Signed-off-by: Ankita Thomas <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 908da0c05363da40ad09ab774d9904b22aca7869

---------

Signed-off-by: Ankita Thomas <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 75b4524 and 2 for PR HEAD 0365511 in total

@ankitathomas
Copy link
Contributor Author

Closing in favor of #796

@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-25341. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

This pull request references Jira Issue OCPBUGS-34173. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2024-06-20 11:19:53 operator-framework/operator-lifecycle-manager@908da0c Ankita Thomas [OCPBUGS-25341]: perform operator apiService certificate validity checks directly (#3217)
2024-06-20 10:00:07 operator-framework/operator-lifecycle-manager@20a3cbc Ankita Thomas [OCPBUGS-34173]: fix sorting unpack jobs (#3299)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants