[release-4.16] OCPBUGS-36138: perform operator apiService certificate validity checks directly #798

ankitathomas · 2024-06-25T02:54:32Z

Manual cherry-pick of 56226d5 to 4.16

…cks directly (#3217) * perform operator apiService certificate validity checks directly Signed-off-by: Ankita Thomas <[email protected]> * use sets to track certs to install, revert to checking for installPlan timeouts after API availability checks, add service FQDN to list of hostnames. Signed-off-by: Ankita Thomas <[email protected]> --------- Signed-off-by: Ankita Thomas <[email protected]>

openshift-ci-robot · 2024-06-25T02:54:38Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-25341, which is invalid:

expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-25341 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of 56226d5 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-06-25T02:55:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [ankitathomas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-06-25T03:01:36Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36138, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of 56226d5 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ankitathomas · 2024-06-25T03:01:39Z

/jira refresh

openshift-ci-robot · 2024-06-25T03:01:43Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36138, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ankitathomas · 2024-06-25T03:13:40Z

/jira refresh

openshift-ci-robot · 2024-06-25T03:13:44Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36138, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ankitathomas · 2024-06-25T03:14:33Z

/jira refresh

openshift-ci-robot · 2024-06-25T03:14:40Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36138, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-25341 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-25341 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2024-06-25T07:54:09Z

/retest

jianzhangbjz · 2024-06-25T13:05:29Z

Test pass, see: https://issues.redhat.com/browse/OCPBUGS-36138
/lgtm
/label qe-approved
/labe cherry-pick-approved

openshift-ci-robot · 2024-06-25T13:06:29Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36138, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-25341 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-25341 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Manual cherry-pick of 56226d5 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-06-25T13:07:46Z

/label cherry-pick-approved

kevinrizza · 2024-06-26T14:18:53Z

/retest
/label backport-risk-assessed

perdasilva · 2024-06-27T06:13:26Z

/retest

openshift-ci · 2024-06-27T09:21:46Z

@ankitathomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-06-27T14:52:14Z

@ankitathomas: Jira Issue OCPBUGS-36138: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#798

Jira Issue OCPBUGS-36138 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of 56226d5 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-06-28T07:17:49Z

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-registry-container-v4.16.0-202406280629.p0.g555e529.assembly.stream.el9 for distgit operator-registry.
All builds following this will include this PR.

ankitathomas · 2024-07-10T13:11:07Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-07-10T13:11:51Z

@ankitathomas: new pull request created: #818

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from joelanford and oceanc80 June 25, 2024 02:54

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024

ankitathomas changed the title ~~[release-4.16] OCPBUGS-25341: perform operator apiService certificate validity checks directly~~ [release-4.16] OCPBUGS-36138: perform operator apiService certificate validity checks directly Jun 25, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 25, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 25, 2024

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2024

openshift-ci bot assigned jianzhangbjz Jun 25, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 26, 2024

openshift-ci bot assigned bandrade Jun 26, 2024

openshift-ci bot assigned emmajiafan, KeenonLee, kuiwang02 and Xia-Zhao-rh Jun 26, 2024

openshift-merge-bot bot merged commit 555e529 into openshift:release-4.16 Jun 27, 2024
13 checks passed

openshift-cherrypick-robot mentioned this pull request Jul 10, 2024

[release-4.15] OCPBUGS-36813: perform operator apiService certificate validity checks directly #818

Closed

ankitathomas mentioned this pull request Jul 10, 2024

[release-4.15] OCPBUGS-36813: [CARRY] perform operator apiService certificate validity checks directly #819

Merged

[release-4.16] OCPBUGS-36138: perform operator apiService certificate validity checks directly #798

[release-4.16] OCPBUGS-36138: perform operator apiService certificate validity checks directly #798

Uh oh!

Conversation

ankitathomas commented Jun 25, 2024

Uh oh!

openshift-ci-robot commented Jun 25, 2024

Uh oh!

openshift-ci bot commented Jun 25, 2024

Uh oh!

openshift-ci-robot commented Jun 25, 2024

Uh oh!

ankitathomas commented Jun 25, 2024

Uh oh!

openshift-ci-robot commented Jun 25, 2024

Uh oh!

ankitathomas commented Jun 25, 2024

Uh oh!

openshift-ci-robot commented Jun 25, 2024

Uh oh!

ankitathomas commented Jun 25, 2024

Uh oh!

openshift-ci-robot commented Jun 25, 2024

Uh oh!

perdasilva commented Jun 25, 2024

Uh oh!

jianzhangbjz commented Jun 25, 2024

Uh oh!

openshift-ci-robot commented Jun 25, 2024

Uh oh!

jianzhangbjz commented Jun 25, 2024

Uh oh!

kevinrizza commented Jun 26, 2024

Uh oh!

perdasilva commented Jun 27, 2024

Uh oh!

openshift-ci bot commented Jun 27, 2024

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 27, 2024

Uh oh!

openshift-bot commented Jun 28, 2024

Uh oh!

ankitathomas commented Jul 10, 2024

Uh oh!

openshift-cherrypick-robot commented Jul 10, 2024

Uh oh!

Uh oh!