Skip to content

OCPBUGS-38119: Update junit report file name to show spec results on Test Grid #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

perdasilva
Copy link
Contributor

I've noticed that the 4.14 test grid shows the individual spec results for the e2e tests. Looking at the diff between what we do in 4.17 and what we do in 4.14, it seems that the only difference is the filename. Updating the junit report filename back to
junit_e2e.xml.

4.14

Screenshot 2024-08-07 at 08 27 13

master (4.17)

Screenshot 2024-08-07 at 08 27 06

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci-robot
Copy link

@perdasilva: This pull request explicitly references no jira issue.

In response to this:

I've noticed that the 4.14 test grid shows the individual spec results for the e2e tests. Looking at the diff between what we do in 4.17 and what we do in 4.14, it seems that the only difference is the filename. Updating the junit report filename back to
junit_e2e.xml.

4.14

Screenshot 2024-08-07 at 08 27 13

master (4.17)

Screenshot 2024-08-07 at 08 27 06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort
Copy link
Contributor

tmshort commented Aug 7, 2024

/lgtm
But is it possible that it's a difference in ginkgo output?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1fb6193 into openshift:master Aug 7, 2024
13 checks passed
@perdasilva perdasilva changed the title NO-ISSUE: Update junit report file name to show spec results on Test Grid OCPBUGS-38119: Update junit report file name to show spec results on Test Grid Aug 7, 2024
@openshift-ci-robot
Copy link

@perdasilva: Jira Issue OCPBUGS-38119: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38119 has been moved to the MODIFIED state.

In response to this:

I've noticed that the 4.14 test grid shows the individual spec results for the e2e tests. Looking at the diff between what we do in 4.17 and what we do in 4.14, it seems that the only difference is the filename. Updating the junit report filename back to
junit_e2e.xml.

4.14

Screenshot 2024-08-07 at 08 27 13

master (4.17)

Screenshot 2024-08-07 at 08 27 06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Contributor Author

/lgtm But is it possible that it's a difference in ginkgo output?

I reached out to @stevekuznetsov before and he reckoned TG 👀 at the junit report. I was guessing it could be related to the file name. Maybe it looks for junit-*.xml ?

@perdasilva
Copy link
Contributor Author

/cherry-pick release-4.16,release-4.15

@openshift-cherrypick-robot

@perdasilva: cannot checkout release-4.16,release-4.15: error checking out "release-4.16,release-4.15": exit status 1 error: pathspec 'release-4.16,release-4.15' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.16,release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@grokspawn
Copy link
Contributor

Are there multiple cherry-pick commands ('cherry-pick', 'cherrypick')? This doc suggests there are, so I'm confused.

@perdasilva
Copy link
Contributor Author

Are there multiple cherry-pick commands ('cherry-pick', 'cherrypick')? This doc suggests there are, so I'm confused.

trying /jira backport to see if that works better =D

@perdasilva
Copy link
Contributor Author

/jira backport release-4.16, release-4.15

@grokspawn
Copy link
Contributor

grokspawn commented Aug 7, 2024

(doc shows no spaces between releases in /jira backport command. Is it that sensitive tokenizing?)

@stevekuznetsov
Copy link
Contributor

I can't remember for the life of me how TestGrid determines the corpus of results to ingest. Naively I was assuming if the Prow/Deck overview for a single job shows individual tests, then TestGrid would know how to find them. Make sure your TestGrid configuration knows about all of your branches and jobs, though.

/cherry-pick release-4.16 release-4.15

@openshift-cherrypick-robot

@stevekuznetsov: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

I can't remember for the life of me how TestGrid determines the corpus of results to ingest. Naively I was assuming if the Prow/Deck overview for a single job shows individual tests, then TestGrid would know how to find them. Make sure your TestGrid configuration knows about all of your branches and jobs, though.

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevekuznetsov
Copy link
Contributor

🙃

The robots don't like me any more, but that's the command you want to use.

@perdasilva
Copy link
Contributor Author

/cherry-pick release-4.16 release-4.15

@openshift-cherrypick-robot

@perdasilva: #832 failed to apply on top of branch "release-4.16":

Applying: Update junit report file name to show spec results on Test Grid
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update junit report file name to show spec results on Test Grid
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Aug 7, 2024
NO-ISSUE: Update junit report file name to show spec results on Test Grid
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.18.0-202408071912.p0.g1fb6193.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.18.0-202408071912.p0.g1fb6193.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.18.0-202408071912.p0.g1fb6193.assembly.stream.el9.
All builds following this will include this PR.

@jianzhangbjz
Copy link
Contributor

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 12, 2024
@openshift-ci-robot
Copy link

@perdasilva: Jira Issue OCPBUGS-38119 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

I've noticed that the 4.14 test grid shows the individual spec results for the e2e tests. Looking at the diff between what we do in 4.17 and what we do in 4.14, it seems that the only difference is the filename. Updating the junit report filename back to
junit_e2e.xml.

4.14

Screenshot 2024-08-07 at 08 27 13

master (4.17)

Screenshot 2024-08-07 at 08 27 06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/operator-framework-olm that referenced this pull request Aug 12, 2024
NO-ISSUE: Update junit report file name to show spec results on Test Grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants