[release-4.15] OCPBUGS-38383: (fix) Resolver: list CatSrc using client, instead of referring to registry-server cache #840
Conversation
…istry-server cache (#3349)
Using "available CatalogSources" information from the registry-client cache was causing
cache inconsistency problems.
This has showed up multiple times in production environments over the years, manifesting
itself in the form of the all subscriptions in a namespace being transitioned into an error
state when a Catalogsource that the cache claims to exist, has actually been deleted from the
cluster, but the cache was not updated.
The Subscriptions are transitioned to an error state because of the deleted catalogsource
with the follwing error message:
"message": "failed to populate resolver cache from source <deleted-catalogsource>: failed to list
bundles: rpc error: code = Unavailable desc = connection error: desc = \"transport:
Error while dialing dial tcp: lookup <deleted-catalogsource>.<ns>.svc on 172.....: no such host\"",
"reason": "ErrorPreventedResolution",
"status": "True",
"type": "ResolutionFailed"
This PR switches the information lookup from the cache, to using a client to list the CatalogSources
present in the cluster.
Upstream-repository: operator-lifecycle-manager
Upstream-commit: ff9084a24b19848c02c2cd4b7d827e057f7f8b11
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-38290 has been cloned as Jira Issue OCPBUGS-38383. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38383, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh /retest |
openshift-ci-robot
added
jira/valid-bug
|
@anik120: This pull request references Jira Issue OCPBUGS-38383, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
bandrade,
emmajiafan,
jianzhangbjz,
KeenonLee,
kuiwang02 and
Xia-Zhao-rh
|
/lgtm |
|
/label backport-risk-assessed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Xia-Zhao-rh fyi this is waiting on a |
|
/lgtm |
openshift-ci
bot
added
qe-approved
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38383, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Xia-Zhao-rh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 5cf4c77
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-38383: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-38383 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: operator-lifecycle-manager |
|
[ART PR BUILD NOTIFIER] Distgit: operator-registry |
|
/cherry-pick release-4.14 |
|
@anik120: #840 failed to apply on top of branch "release-4.14": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #838
/assign anik120