Bug 1958296: Surface API server warnings when applying plan steps. #85
Conversation
openshift-ci
bot
added
bugzilla/severity-urgent
|
@benluddy: This pull request references Bugzilla bug 1958296, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Upstream-commit: d0d208d8eda8f7ff45df6e70d370fcee08addb66 Upstream-repository: operator-lifecycle-manager
Responses from the API server may include RFC2616 14.46 warnings (for example, due to deprecation). Since the catalog-operator creates and updates cluster resources on behalf of users, these warnings should be surfaced to users. When at least one warning is returned during the creation or update of a step resource, catalog-operator now creates an Event with reason "AppliedWithWarnings", involvedObject and fieldPath set to the plan and step that generated the warning, respectively, and its message containing the warning text. In addition, a new metric, "installplan_warnings_total", counts the number of steps that have been applied with warnings. Upstream-commit: 2c623e1e4877608fd16a6089a6aeeac5b1217f18 Upstream-repository: operator-lifecycle-manager
|
/hold cancel |
openshift-ci
bot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold Test flakiness should go down once #88 merges (affecting e2e-aws-olm), but e2e-gcp is failing due to a test of the alert trigger condition (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_operator-framework-olm/85/pull-ci-openshift-operator-framework-olm-master-e2e-gcp/1401961122583547904). |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold-cancel |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold Looks like we're waiting on openshift/origin#26211 too |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
@benluddy: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1958296 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@davegord: All pull requests linked via external trackers have merged: Bugzilla bug 1958296 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Responses from the API server may include RFC2616 14.46 warnings (for
example, due to deprecation). Since the catalog-operator creates and
updates cluster resources on behalf of users, these warnings should be
surfaced to users.
When at least one warning is returned during the creation or update of
a step resource, catalog-operator now creates an Event with reason
"AppliedWithWarnings", involvedObject and fieldPath set to the plan
and step that generated the warning, respectively, and its message
containing the warning text.
In addition, a new metric, "installplan_warnings_total", counts the
number of steps that have been applied with warnings.