Skip to content

OCPBUGS-42828: add optional schema migrations; default to olm.bundle.object instead of olm.csv.metadata #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

grokspawn
Copy link
Contributor

… (#1384)

  • Allow disabling of migrations for bundles and sqlite DBs
  • intro new migrations package
  • schema migration optional; default to olm.bundle.object
  • review resolutions
  • use a type to protect migration interactions
  • review revisions

Upstream-repository: operator-registry
Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a

…of olm.csv.metadata (#1384)

* Allow disabling of migrations for bundles and sqlite DBs

Signed-off-by: Joe Lanford <[email protected]>

* intro new migrations package

Signed-off-by: Joe Lanford <[email protected]>

* schema migration optional; default to olm.bundle.object

Signed-off-by: Jordan Keister <[email protected]>

* review resolutions

Signed-off-by: Jordan Keister <[email protected]>

* use a type to protect migration interactions

Signed-off-by: Jordan Keister <[email protected]>

* review revisions

Signed-off-by: Jordan Keister <[email protected]>

---------

Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Jordan Keister <[email protected]>
Co-authored-by: Joe Lanford <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a
Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@grokspawn
Copy link
Contributor Author

/jira cherrypick OCPBUGS-42114

@openshift-ci-robot
Copy link

@grokspawn: Jira Issue OCPBUGS-42114 has been cloned as Jira Issue OCPBUGS-42828. Will retitle bug to link to clone.
/retitle OCPBUGS-42828: add optional schema migrations; default to olm.bundle.object instead of olm.csv.metadata

In response to this:

/jira cherrypick OCPBUGS-42114

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title add optional schema migrations; default to olm.bundle.object instead of olm.csv.metadata OCPBUGS-42828: add optional schema migrations; default to olm.bundle.object instead of olm.csv.metadata Oct 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 7, 2024
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-42828, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42114 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-42114 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… (#1384)

  • Allow disabling of migrations for bundles and sqlite DBs
  • intro new migrations package
  • schema migration optional; default to olm.bundle.object
  • review resolutions
  • use a type to protect migration interactions
  • review revisions

Upstream-repository: operator-registry
Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@grokspawn
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 8, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@emmajiafan
Copy link

/lgtm
/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 8, 2024
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-42828, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42114 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-42114 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

… (#1384)

  • Allow disabling of migrations for bundles and sqlite DBs
  • intro new migrations package
  • schema migration optional; default to olm.bundle.object
  • review resolutions
  • use a type to protect migration interactions
  • review revisions

Upstream-repository: operator-registry
Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b18c1b3 into openshift:release-4.14 Oct 8, 2024
13 checks passed
@openshift-ci-robot
Copy link

@grokspawn: Jira Issue OCPBUGS-42828: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42828 has been moved to the MODIFIED state.

In response to this:

… (#1384)

  • Allow disabling of migrations for bundles and sqlite DBs
  • intro new migrations package
  • schema migration optional; default to olm.bundle.object
  • review resolutions
  • use a type to protect migration interactions
  • review revisions

Upstream-repository: operator-registry
Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.14.0-202410080809.p0.gb18c1b3.assembly.stream.el8.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202410080809.p0.gb18c1b3.assembly.stream.el8.
All builds following this will include this PR.

@grokspawn grokspawn deleted the bundle-object-4.14 branch October 8, 2024 12:55
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-10-08-132251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.