[release-4.17] OCPBUGS-43965: Return an error when the IP status cannot be updated

[tmshort]

This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP.

Signed-off-by: Todd Short [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a63b449eb6ee44d716e6e21aae639db217ebb6e1 (cherry picked from commit 9500f27)

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-43964, which is invalid:

• expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP.

Signed-off-by: Todd Short [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a63b449eb6ee44d716e6e21aae639db217ebb6e1 (cherry picked from commit 9500f27)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-43965, which is invalid:

• expected the bug to target the "4.17.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-43965 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP.

Signed-off-by: Todd Short [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a63b449eb6ee44d716e6e21aae639db217ebb6e1 (cherry picked from commit 9500f27)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tmshort]

/jira refresh

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-43965, which is invalid:

• expected the bug to target the "4.17.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-43965 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tmshort]

/jira refresh

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-43965, which is invalid:

• expected dependent Jira Issue OCPBUGS-37637 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[perdasilva]

/jira refresh

[openshift-ci-robot]

@perdasilva: This pull request references Jira Issue OCPBUGS-43965, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-37637 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-37637 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/label backport-risk-assessed

[perdasilva]

/lgtm

[jianzhangbjz]

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-43965
/label cherry-pick-approved
/label qe-approved

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-43965, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-37637 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-37637 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP.

Signed-off-by: Todd Short [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a63b449eb6ee44d716e6e21aae639db217ebb6e1 (cherry picked from commit 9500f27)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tmshort: Jira Issue OCPBUGS-43965: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#885

Jira Issue OCPBUGS-43965 has been moved to the MODIFIED state.

In response to this:

This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP.

Signed-off-by: Todd Short [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a63b449eb6ee44d716e6e21aae639db217ebb6e1 (cherry picked from commit 9500f27)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.17.0-202410311235.p0.g4cbfa45.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.17.0-202410311235.p0.g4cbfa45.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.17.0-202410311235.p0.g4cbfa45.assembly.stream.el9.
All builds following this will include this PR.

[wangke19]

/jira refresh

[openshift-ci-robot]

@wangke19: Jira Issue OCPBUGS-43965 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wangke19]

/jira refresh

[openshift-ci-robot]

@wangke19: Jira Issue OCPBUGS-43965: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#885

Jira Issue OCPBUGS-43965 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.