-
Notifications
You must be signed in to change notification settings - Fork 71
use ubi instead of scratch #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jianzhangbjz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jianzhangbjz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hi @jianzhangbjz |
Bundles images explicitly should NOT be multi-arch images. They contain just plaintext files, so they are not platform-specific. Only images that contain executable binaries need to be multi-arch. And the manifests inside of a bundle images should always reference the multi-arch manifest of the controller and related images. Is the validate bundle command failing on scratch-based bundle images? |
Hi @jianzhangbjz. I think we can close this PR. We downstreamed operator-framework/operator-registry/#1519 as #933 which would give folks the ability to substitute a different base image if they cannot use scratch. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Great! Thanks! I closed this one. |
I'm not sure if I should modify the downstream directly, but some users have conerns when using the
scratch
, especially when building the multi-arch image. They have to modify the Dockfile afteropm alpha bundle generate xxx
. They will get an error if they forget to update the base image. So, I just submitted this PR, any comments are welcome! Thanks!