Skip to content

OCPBUGS-42526: The openshift-operator-lifecycle-manager namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Mar 3, 2025

See that we have also a PR to change the files used in upstream: #966
However, this one is specific to downstream/OCP manifests

@openshift-ci openshift-ci bot requested review from dinhxuanvu and joelanford March 3, 2025 13:29
@camilamacedo86 camilamacedo86 changed the title Fix psa NO-ISSUE: fix: update PSA versions to match Kubernetes API version Mar 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Closes: https://github.com/openshift/operator-framework-olm/pull/966/commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-console-olm

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-console-olm

1 similar comment
@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-console-olm

@jianzhangbjz
Copy link
Contributor

Hi @camilamacedo86 , I guess this PR is for https://issues.redhat.com/browse/OCPBUGS-42526, right? If yes, it's better to add the OCPBUGS-42526 strgins as the PR title prefix so that JIRA bot can update the status automatically.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Mar 4, 2025

Hi @jianzhangbjz

Hi @camilamacedo86 , I guess this PR is for https://issues.redhat.com/browse/OCPBUGS-42526, right? If yes, it's better to add the OCPBUGS-42526 strgins as the PR title prefix so that JIRA bot can update the status automatically.

We need a Jira for each OCP version / component :-(
I will create the JIRAs

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: fix: update PSA versions to match Kubernetes API version WIP: fix: update PSA versions to match Kubernetes API version Mar 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-console-olm

@jianzhangbjz
Copy link
Contributor

We need a Jira for each OCP version / component :-(
I will create the JIRAs

Yes, but I don't think you need to do this manually. Once cherry-pick release-4.18 is labeled, the jira-bot will create it automatically. But, you need to add the bug ID as the title prefix.

@jianzhangbjz
Copy link
Contributor

And, I tested this PR, looks good, details: https://issues.redhat.com/browse/OCPBUGS-42526
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 4, 2025
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 changed the title WIP: fix: update PSA versions to match Kubernetes API version OCPBUGS-52318: update PSA versions to match Kubernetes API version Mar 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-52318, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: https://github.com/openshift/operator-framework-olm/pull/966/commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title OCPBUGS-52318: update PSA versions to match Kubernetes API version OCPBUGS-52318: Fix OCP PSA labels for OCP manifests with k8s version Mar 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-52318, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

See that we have also a PR to change the files used in upstream: #966
However, this one is specific to downstream/OCP manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Contributor

Hi @camilamacedo86 , this PR should be for https://issues.redhat.com/browse/OCPBUGS-42526 instead of https://issues.redhat.com/browse/OCPBUGS-52318. Because OLMv0 never uses the latest PSA label.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Mar 5, 2025

Hi @jianzhangbjz

Hi @camilamacedo86 , this PR should be for https://issues.redhat.com/browse/OCPBUGS-42526 instead of https://issues.redhat.com/browse/OCPBUGS-52318. Because OLMv0 never uses the latest PSA label.

I could not use the original one for it because we need to do the same for other components, OLMv1 and the marketplace. So, if we use OCPBUGS-42526 for all when the first gets merged, we will have problems with the others.
But I see your point about the title and content being wrong. I will fix that. Thank you

@camilamacedo86 camilamacedo86 changed the title OCPBUGS-52318: Fix OCP PSA labels for OCP manifests with k8s version OCPBUGS-52318: The openshift-operator-lifecycle-manager and openshift-marketplace namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively Mar 5, 2025
@camilamacedo86
Copy link
Contributor Author

/retest-required

@jianzhangbjz
Copy link
Contributor

I could not use the original one for it because we need to do the same for other components, OLMv1 and the marketplace.

Sorry, but why? This PR is for OLMv0, not OLMv1.

@camilamacedo86 camilamacedo86 changed the title OCPBUGS-52318: The openshift-operator-lifecycle-manager and openshift-marketplace namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively OCPBUGS-52318: The openshift-operator-lifecycle-manager namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively Mar 5, 2025
@camilamacedo86
Copy link
Contributor Author

HI @jianzhangbjz

Sorry, but why? This PR is for OLMv0, not OLMv1.

We need a JIRA for each version / project
The JIRA is for all projects and versions: https://issues.redhat.com/browse/OCPBUGS-42526
So, as we spoke via slack and here: https://issues.redhat.com/browse/OCPBUGS-42526?focusedId=26710231&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-26710231
We cannot use it for ALL prs.

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-console-olm

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

/test e2e-gcp-console-olm

@camilamacedo86
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm-flaky 9556780 link false /test e2e-gcp-olm-flaky
ci/prow/e2e-gcp-olm 9556780 link true /test e2e-gcp-olm
ci/prow/e2e-gcp-console-olm 9556780 link true /test e2e-gcp-console-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jianzhangbjz
Copy link
Contributor

Based on https://redhat-internal.slack.com/archives/C06KP34REFJ/p1741224828143489?thread_ts=1739880491.760029&cid=C06KP34REFJ, we should use the latest instead of the pinned version.

@jianzhangbjz
Copy link
Contributor

/hold
/remove-label qe-approved

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed qe-approved Signifies that QE has signed off on this PR labels Mar 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 6, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-52318, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

See that we have also a PR to change the files used in upstream: #966
However, this one is specific to downstream/OCP manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Contributor

/retitle OCPBUGS-42526: The openshift-operator-lifecycle-manager namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively

@openshift-ci openshift-ci bot changed the title OCPBUGS-52318: The openshift-operator-lifecycle-manager namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively OCPBUGS-42526: The openshift-operator-lifecycle-manager namespaces still use old pod-security.kubernetes.io/*-version v1.24 and v1.25 respectively Mar 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-42526, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

See that we have also a PR to change the files used in upstream: #966
However, this one is specific to downstream/OCP manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

Closing since QE would like to set latest instead

@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-42526. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

See that we have also a PR to change the files used in upstream: #966
However, this one is specific to downstream/OCP manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants