Skip to content

Commit 5678e58

Browse files
authored
Add format as a prerequisite to verify target (#200)
This commit updates the verify target to include the format target as a prerequisite. This commit also includes changes introduced after running the format target.
1 parent eceda8b commit 5678e58

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ TEST_PKGS:=$(shell go list ./...)
8585
test-unit: ## Run the unit tests
8686
$(Q)go test -count=1 -short ${TEST_PKGS}
8787

88-
verify: manifests generate
88+
verify: manifests generate format
8989
git diff --exit-code
9090

9191
# Utilities.

crds/zz_defs.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/validation/internal/bundle.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ func validateServiceAccounts(bundle *manifests.Bundle) []errors.Error {
5252
sa := v1.ServiceAccount{}
5353
if err := runtime.DefaultUnstructuredConverter.FromUnstructured(obj.Object, &sa); err == nil {
5454
if _, ok := saNamesFromCSV[sa.Name]; ok {
55-
errs = append(errs, errors.ErrInvalidBundle(fmt.Sprintf("invalid service account found in bundle. " +
56-
"This service account %s in your bundle is not valid, because a service account with the same name " +
57-
"was already specified in your CSV. If this was unintentional, please remove the service account " +
58-
"manifest from your bundle. If it was intentional to specify a separate service account, " +
59-
"please rename the SA in either the bundle manifest or the CSV.",sa.Name), sa.Name))
55+
errs = append(errs, errors.ErrInvalidBundle(fmt.Sprintf("invalid service account found in bundle. "+
56+
"This service account %s in your bundle is not valid, because a service account with the same name "+
57+
"was already specified in your CSV. If this was unintentional, please remove the service account "+
58+
"manifest from your bundle. If it was intentional to specify a separate service account, "+
59+
"please rename the SA in either the bundle manifest or the CSV.", sa.Name), sa.Name))
6060
}
6161
}
6262
}

0 commit comments

Comments
 (0)