This repository was archived by the owner on Sep 21, 2020. It is now read-only.
Update apiVersion to operators.coreos.com/v1alpha1 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilic
reviewed
Sep 19, 2018
memcachedoperator.0.0.2.csv.yaml
Outdated
| @@ -1,7 +1,7 @@ | |||
| # This file defines the ClusterServiceVersion (CSV) to tell the catalog how to display, create and | |||
| # manage the application as a whole. If changes are made to the CRD for this application kind, | |||
| # make sure to replace those references below as well. | |||
| apiVersion: app.coreos.com/v1alpha1 | |||
| apiVersion: operators.coreos.com/v1alpha1 | |||
| kind: ClusterServiceVersion-v1 | |||
There was a problem hiding this comment.
The -v1 also needs to be removed.
memcachedoperator.0.0.1.csv.yaml
Outdated
| @@ -1,7 +1,7 @@ | |||
| # This file defines the ClusterServiceVersion (CSV) to tell the catalog how to display, create and | |||
| # manage the application as a whole. If changes are made to the CRD for this application kind, | |||
| # make sure to replace those references below as well. | |||
| apiVersion: app.coreos.com/v1alpha1 | |||
| apiVersion: operators.coreos.com/v1alpha1 | |||
| kind: ClusterServiceVersion-v1 | |||
There was a problem hiding this comment.
The -v1 also needs to be removed.
|
Also I noticed in the README there is a query that should be removed that includes the |
csv is defined under operators.coreos.com group in the latest version of OLM.
darkowlzz
force-pushed
the
apiversion-update
branch
from
5b77b11 to
c85fc82
Compare
|
oops! 😅 I thought I did remove |
|
Thanks for putting this PR together! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csv is defined under
operators.coreos.comgroup in the latest versionof OLM.
Fixes #21