This repository was archived by the owner on Jan 25, 2019. It is now read-only.
cmd/helm-app-operator,pkg/helm: Updating dependencies; Support out-of-cluster mode #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasbro17
reviewed
Oct 9, 2018
helm-app-operator/Gopkg.toml
Outdated
|
|
||
| [[override]] | ||
| name = "sigs.k8s.io/controller-runtime" | ||
| version = "v0.1.3" |
There was a problem hiding this comment.
version = "v0.1.4" like in the parent PR:
https://github.com/operator-framework/helm-app-operator-kit/pull/43/files#diff-8ed8aebc54045fa00fcf8481f153d8deR40
So we have the namespace option support.
hasbro17
reviewed
Oct 9, 2018
helm-app-operator/Gopkg.toml
Outdated
| [prune] | ||
| go-tests = true | ||
| non-go = true | ||
| unused-packages = true |
There was a problem hiding this comment.
Just a heads up if you have unsued-packages here you'll have to run dep ensure again once you add in new files that have new dependencies.
That's why we actually removed this in the refactor branch.
So either remove this, or just remember to run dep ensure again when you add in new deps.
This was referenced Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller-runtime) operator-sdk scaffolding