Add instructions to reference pull secret from bundle #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SRodi
commented
Dec 4, 2023
SRodi
commented
- add instructions for image pull from private registry within bundle
- relates to Private Container Registry: operator-sdk run bundle can't start controller-manager pod due to incorrect imagePullSecret reference operator-sdk#6622
* add instructions for image pull from private registry within bundle * relates to operator-framework/operator-sdk#6622 Signed-off-by: Simone-Rodigari <[email protected]>
kevinrizza
reviewed
Dec 5, 2023
| If the `imagePullSecret` is referenced in the bundle, for instance when the controller-manager image is pulled from a private registry, there is no place in the API to tell OLM to attach the `imagePullSecrets`. As a consequence, permissions to pull the image should be added directly to the controller-manager deployment configurations. This can be achieved by updating `config/manager/manager.yaml` and adding `deployment.spec.template.spec.imagePullSecrets` with the required secret name. |
There was a problem hiding this comment.
Can you make this comment a little bit more generic? Instead of added directly to the controller-manager deployment configurations, something like added directly to the operator deployment's podspec. Then update that last sentence to contextualize it around "here's how that works for the operator-sdk's abstraction" in some way?
* make the instruction more generic * provide an example for operator-sdk Signed-off-by: Simone-Rodigari <[email protected]>
|
/lgtm |
kevinrizza
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.