Improve look and feel of olm site #67
Conversation
| export olm_release=0.15.1 | ||
| kubectl apply -f https://github.com/operator-framework/operator-lifecycle-manager/releases/download/${olm_release}/crds.yaml | ||
| kubectl apply -f https://github.com/operator-framework/operator-lifecycle-manager/releases/download/${olm_release}/olm.yaml | ||
| ```sh |
There was a problem hiding this comment.
If we expect users to copy these shell commands verbatim then I suggest we do not prepend $ to each line of a sh block; this prefix is only visually useful when using a console block with command output as an example.
There was a problem hiding this comment.
That makes sense, I prepended the $ prefix to match the style on the SDK website, but I have corrected it.
| @@ -18,9 +18,9 @@ | |||
| {{ range $pages }} | |||
| {{ if eq .Parent $parent }} | |||
| <div class="entry"> | |||
| <h5> | |||
| <h3> | |||
There was a problem hiding this comment.
This folder is a sub-module(i,e vendored), and therefore should not be changed. If we want to make a change to any of these files, we need to copy them in the root folder and make these changes.
For example, this particular file needs to be copied to the partials folder in our root to make these changes.
There was a problem hiding this comment.
I have undone the changes to vendor files and created a new file in the layouts/partials directory.
layouts/docs/single.html
Outdated
| @@ -0,0 +1,3 @@ | |||
| {{ define "main" }} | |||
| {{ .Render "content" }} | |||
| {{ end }} | |||
There was a problem hiding this comment.
nit: please add a new line to this file
| @@ -17,7 +17,8 @@ | |||
| h1,h2,h3,h4,h5,h6 { | |||
| color: var(--of--Color--brand--200); | |||
| font-weight: 800; | |||
| margin: var(--of--spacer--md) 0 var(--of--spacer--sm); | |||
| letter-spacing: 2px; | |||
There was a problem hiding this comment.
@anmol372 could we revert this change? We specifically wanted margin: var(--of--spacer--md) 0 var(--of--spacer--sm); because the spacing between the heading was looking really bad
|
@anmol372 could you squash your commits please |
anmol372
changed the title
anmol372
force-pushed
the
expNetlify
branch
from
bdc84c8 to
6fcf924
Compare
|
@anmol372 could you rebase your changes off the latest master please |
openshift-ci-robot
added
the
needs-rebase
Changes: 1. Added styling imports from themes/docsy 2. Corrected font family, sizing, and letter-spacing for docs 3. Increased size of headings on the site to make them larger than their subtexts.
openshift-ci-robot
removed
the
needs-rebase
Changes: