Skip to content

Create APIService after API server deployment #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Create APIService after API server deployment #1418

merged 1 commit into from
Apr 3, 2020

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Apr 1, 2020

This commit introduces a change so the APISerivce is created after the
API Server is successfully deployed on the cluster.

@exdx
Copy link
Member

exdx commented Apr 1, 2020

/lgtm

Looks a little funny returning the map everywhere, but no way around it outside of a named return (which I personally don't like) and I don't think work in cases where only one return argument is named and others are not. Pointers to maps also don't work. Putting the map on the Operator object as an attribute also doesn't seem right. So lets leave it as is.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
exdx
exdx reviewed Apr 1, 2020
View reviewed changes
@awgreene awgreene force-pushed the apiservce-reorder branch from 066c718 to 2bec9d5 Compare April 1, 2020 22:50
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
exdx
exdx reviewed Apr 2, 2020
View reviewed changes
@awgreene awgreene force-pushed the apiservce-reorder branch from 2bec9d5 to 868ab99 Compare April 2, 2020 14:29
@awgreene
Create APIService after API server deployment
45a06b8 
This commit introduces a change so the APISerivce is created after the
API Server is successfully deployed on the cluster.
@awgreene awgreene force-pushed the apiservce-reorder branch from 868ab99 to 45a06b8 Compare April 2, 2020 14:45
@exdx
Copy link
Member

exdx commented Apr 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@awgreene
Copy link
Member Author

awgreene commented Apr 2, 2020

[Fail] Install Plan with CRD schema change Test [It] existing version is present in new CRD (deprecated field)

Ran just fine locally.

/retest

@ecordell
Copy link
Member

ecordell commented Apr 2, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@awgreene
Copy link
Member Author

awgreene commented Apr 2, 2020

/retest

@awgreene
Copy link
Member Author

awgreene commented Apr 2, 2020

/retest
delete internal registry pod triggers recreation

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3ba5db8 into operator-framework:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exdx exdx exdx left review comments

@ecordell ecordell Awaiting requested review from ecordell

@njhale njhale Awaiting requested review from njhale

Assignees

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awgreene @exdx @ecordell @openshift-ci-robot @openshift-bot @openshift-merge-robot