Skip to content

(Rebased disc)^2 #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 22, 2020
Merged

(Rebased disc)^2 #1468

merged 14 commits into from
Apr 22, 2020

Conversation

njhale
Copy link
Member

@njhale njhale commented Apr 20, 2020

Description of the change:

Rebase on master after the operator-framework/api updates! Again!

Add the operators.coreos.com/v2alpha1 API group and Operator resource with component selection.

njhale added 11 commits April 20, 2020 06:58
@njhale
feat(operators): add v2alpha1 operator controller
a35b4d0 
Add support for reconciling the v2alpha1 Operator API:
- generate Operator resources when none exist and labeled components
  found
- aggregate component references in the status of their respective
  Operators
- aggregate component status conditions to their respective Operators
- enabled by specifying the "OperatorLifecycleManagerV2" feature gate option
  when invoking the olm command

Also:
- regenerate clients and fakes
@njhale
test(operators): add e2e test for the v2alpha1 operator resource
c984467 
- Add an e2e test for the v2alpha1 Operator resource
- Add some e2e utilities for watching resource changes
@njhale
chore(logs): set manager setup log level to 4
f21dd11
@njhale
chore(make): use existing kubebuilder installation
0167640 
- Make kubebuilder assets configurable using the KUBEBUILDER_ASSETS
  environment variable
- Remove automatic kubebuilder installation
- Throw make error if any kubebuilder assets are missing
@njhale
test(lib): add unit test for metav1 time conversion hook
47ccb86
@njhale
feat(operator): enable configmaps to be operator components
4e00700 
- Add ConfigMaps to the set of resource types that can be Operator
  components (tracked by the controller)
- Remove extra comment
- Remove unused dynamic source implementation
@njhale
fix(operator): swap top-level update for status update
93b8c3e 
For some reason the top-level update call was allowing updates to
Operator CR status subresources when its CRD was submitted as
v1beta1. Status updates broke as soon as we updated to v1 CRDs and the
status specific update became required.
@njhale
test(operator): gracefully stop test controller manager
3cdc00e 
Stop Operator unit test controller manager before stopping testenv to
prevent moot error message spam in test output.
@njhale
fix(client): supply missing params
15a3068
@njhale
chore(manifests): include double-hyphen olm deployment options
0f5eb23 
Regenerate the OLM deployment manifest to include double-hyphenated
comments. This is necessary to support the use of the pflag module.
@njhale
chore(modules): pin controller-runtime to master
29736bf
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@njhale njhale mentioned this pull request Apr 20, 2020
Closed
5 tasks
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@njhale
Copy link
Member Author

njhale commented Apr 20, 2020

/retest

1 similar comment
@ecordell
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

njhale added 3 commits April 21, 2020 09:30
@njhale
test(e2e): simplify csv requirement event spec
6c62c04
@njhale
test(e2e): make operator resource creation eventual
79f02e6 
Fix operator status spec flake by making resource creation check
eventual.
@njhale
test(e2e): correct tls detection in metrics spec
224add1 
The metrics e2e test spec was failing to detect olm-operator pod TLS
flags.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@ecordell
Copy link
Member

/retest

3 similar comments
@ecordell
Copy link
Member

/retest

@njhale
Copy link
Member Author

njhale commented Apr 21, 2020

/retest

@njhale
Copy link
Member Author

njhale commented Apr 21, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@shawn-hurley shawn-hurley added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit ed17b12 into operator-framework:master Apr 22, 2020
@jianzhangbjz
Copy link
Contributor

for story: https://issues.redhat.com/browse/OLM-1420

@njhale njhale deleted the op-disc branch July 23, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@njhale @openshift-ci-robot @ecordell @openshift-bot @jianzhangbjz @shawn-hurley @openshift-merge-robot