Bug 1830031: Update OLM to use UID for OG Labels #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
bugzilla/severity-medium
|
@awgreene: This pull request references Bugzilla bug 1830031, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
benluddy
reviewed
May 1, 2020
|
/approve |
openshift-ci-robot
added
the
approved
|
It looks like a libcontainer package using CGO is being transitively pulled in via the latest operator-registry: https://github.com/operator-framework/operator-lifecycle-manager/pull/1496/checks?check_run_id=637003810, which breaks the upstream image build. It has +nocgo implementations, though. |
|
Looks like there's a legitimate E2E failure -- OpenShift Prow was broken over most of the weekend and incorrectly marking failing checks green. /test e2e-aws-olm |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/test unit |
|
/retest |
njhale
reviewed
May 6, 2020
| @@ -2096,7 +2096,7 @@ var _ = Describe("Operator Group", func() { | |||
| }() | |||
|
|
|||
| // Create the OperatorGroup Label | |||
| ogLabel := fmt.Sprintf("olm.operatorgroup/%s.%s", testNamespaceA, operatorGroup.GetName()) | |||
There was a problem hiding this comment.
Note: can we make this a method of *OperatorGroup or a wrapper?
|
/retest |
benluddy
reviewed
May 6, 2020
Problem: OLM is using an older version of the operator-framework/api repository with which OLM applies a label with a blank value whose key is equal to "olm.operatorgroup/.". Kubernetes limits the lengths of label values and keys to 63 characters. This limit can easily be overcome when the OperatorGroup has a long name or when it is deployed in a namespace with a long name. Solution: Update OLM to use import the latest version of the operator-framework/api repository that uses "olm.operatorgroup.uid/" as the key for OperatorGroup labels. The length of this label will always be 58 characters as UIDs are 36 characters long.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, benluddy, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@awgreene: All pull requests linked via external trackers have merged: operator-framework/api#31, operator-framework/operator-lifecycle-manager#1496. Bugzilla bug 1830031 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@awgreene: #1496 failed to apply on top of branch "release-4.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
OLM is using an older version of the operator-framework/api repository
with which OLM applies a label with a blank value whose key is equal to
"olm.operatorgroup/.".
Kubernetes limits the lengths of label values and keys to 63 characters.
This limit can easily be overcome when the OperatorGroup has a long name
or when it is deployed in a namespace with a long name.
Solution:
Update OLM to use import the latest version of the operator-framework/api
repository that uses "olm.operatorgroup.uid/" as the key
for OperatorGroup labels. The length of this label will always be 58
characters as UIDs are 36 characters long.