Skip to content

Convert scoped_client_test to ginkgo #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

Convert scoped_client_test to ginkgo #1500

merged 1 commit into from
Oct 29, 2020

Conversation

harishsurf
Copy link
Contributor

Description of the change:
The change converts scoped_e2e_test.go to ginkgo

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@harishsurf harishsurf force-pushed the scoped-e2e branch 2 times, most recently from 2d70470 to 057b104 Compare May 7, 2020 17:35
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2020
exdx
exdx reviewed May 28, 2020
View reviewed changes
benluddy
benluddy reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@benluddy benluddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Harish! Most of my points are nits or test style comments.

@harishsurf
Copy link
Contributor Author

/retest

Bowenislandsong
Bowenislandsong reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@Bowenislandsong Bowenislandsong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update, small comment otherwise lgtm.

benluddy
benluddy requested changes Jun 24, 2020
View reviewed changes
@of-deploy-bot
Copy link

This PR failed 1 out of 1 times with 2 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
failedtestcount: 1
flaketestcount: 2
skippedtestcount: 4
flaketests:

  • classname: End-to-end
    name: 'Subscription creation with dependencies required and provided in different
    versions of an operator in the same package    '
    counts: 3
    details:

    • count: 3
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:51
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:2, cap:2>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-b",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-b",
                UID: "37271e7c-bc9f-41ab-b0d5-a44fca3a475b",
                ResourceVersion: "2808",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-08-17T16:35:44Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.1310608f9e17b00c": "provided",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depq9kkr",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "insl4m7p.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insl4m7p",
                            DisplayName: "insl4m7p.cluster.com",
                            Description: "insl4m7p.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-08-17T16:35:47Z,
                },
                LastTransitionTime: {
                    Time: 2020-08-17T16:35:47Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:44Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:44Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:44Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:44Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment depq9kkr to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:46Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:47Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:47Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-b",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insl4m7p.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "a2d22021-f481-4a80-89b9-3497a52d7626",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-e",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-e",
                UID: "5089d29f-5574-49f5-8122-72d6d9314017",
                ResourceVersion: "2818",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-08-17T16:35:45Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.9692ab7c658acf44": "provided",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depmm89f",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "insn2d2v.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insn2d2v",
                            DisplayName: "insn2d2v.cluster.com",
                            Description: "insn2d2v.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-08-17T16:35:47Z,
                },
                LastTransitionTime: {
                    Time: 2020-08-17T16:35:47Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment depmm89f to become ready: Waiting for deployment spec update to be observed...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:46Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:45Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-17T16:35:47Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-17T16:35:47Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-e",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insn2d2v.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "6c46f5c5-7535-44c5-925a-5cd0e3def679",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496
    meandurationsec: 82.10072933333333
  • classname: End-to-end
    name: 'Garbage collection for dependent resources when a bundle with a new configmap
    is installed when the subscription is updated to a later CSV with a configmap
    with a new name should have removed the old configmap and put the new configmap
    in place    '
    counts: 1
    details:

    • count: 1
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/gc_e2e_test.go:507
could not get installplan at complete phase
Unexpected error:
    <*errors.errorString | 0xc0001762a0>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/gc_e2e_test.go:547
    meandurationsec: 328.133243
    skippedtests:
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should install the operator
    successfully    '
    counts: 1
    details: []
    meandurationsec: 13.365174
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should have created the expected
    prometheus objects    '
    counts: 1
    details: []
    meandurationsec: 14.096565
  • classname: End-to-end
    name: 'Catalog image update'
    counts: 1
    details: []
    meandurationsec: 0.095921
  • classname: End-to-end
    name: 'Subscription updates existing install plan'
    counts: 1
    details: []
    meandurationsec: 0.024981

@harishsurf
Copy link
Contributor Author

/retest

@harishsurf harishsurf mentioned this pull request Aug 20, 2020
Closed
5 tasks
@exdx exdx self-assigned this Aug 31, 2020
@openshift-ci-robot
Copy link
Collaborator

@harishsurf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade 360723c link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harishsurf
Copy link
Contributor Author

/test e2e-upgrade

@of-deploy-bot
Copy link

This PR failed 1 out of 1 times with 2 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
failedtestcount: 1
flaketestcount: 2
skippedtestcount: 4
flaketests:

  • classname: End-to-end
    name: 'Subscription to an operator with dependencies from different CatalogSources
    with priorities creating CatalogSources providing the same dependency under
    test and global namespaces when creating subscription for the main package
    choose the dependent package from the catsrc in the same namespace as the
    installing operator    '
    counts: 3
    details:

    • count: 3
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:53
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:2, cap:2>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-main",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-main",
                UID: "5e31c682-0699-4394-b0f6-634ba1d7bbf9",
                ResourceVersion: "16529",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-10-27T22:16:23Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.fa52c53963b39404": "required",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                    "operatorframework.io/properties": "{\"properties\":[{\"type\":\"olm.package\",\"value\":{\"packageName\":\"PkgMain-f54k6\",\"version\":\"0.1.0\"}}]}",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depzdbx4",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: nil,
                    Required: [
                        {
                            Name: "inspvksd.cluster.com",
                            Version: "v1alpha1",
                            Kind: "inspvksd",
                            DisplayName: "inspvksd.cluster.com",
                            Description: "inspvksd.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-10-27T22:16:30Z,
                },
                LastTransitionTime: {
                    Time: 2020-10-27T22:16:30Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:23Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:23Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:24Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:23Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment depzdbx4 to become ready: Waiting for deployment spec update to be observed...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:26Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:30Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:30Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-main",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "inspvksd.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "a5388fb0-77f8-4351-992e-a7b732686ffe",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-right",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-right",
                UID: "db4ba9b6-689e-4a75-82ea-178238ff4b4f",
                ResourceVersion: "16481",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-10-27T22:16:24Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.fa52c53963b39404": "provided",
                },
                Annotations: {
                    "olm.targetNamespaces": "",
                    "operatorframework.io/properties": "{\"properties\":[{\"type\":\"olm.gvk\",\"value\":{\"group\":\"cluster.com\",\"kind\":\"inspvksd\",\"version\":\"v1alpha1\"}},{\"type\":\"olm.package\",\"value\":{\"packageName\":\"PackageDependent\",\"version\":\"0.1.0\"}}]}",
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depd8f2f",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "inspvksd.cluster.com",
                            Version: "v1alpha1",
                            Kind: "inspvksd",
                            DisplayName: "inspvksd.cluster.com",
                            Description: "inspvksd.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-10-27T22:16:29Z,
                },
                LastTransitionTime: {
                    Time: 2020-10-27T22:16:29Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment depd8f2f to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:26Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:25Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-10-27T22:16:29Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T22:16:29Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-right",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "inspvksd.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "a5388fb0-77f8-4351-992e-a7b732686ffe",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496
    meandurationsec: 160.55418366666666
  • classname: End-to-end
    name: 'CRD Versions allows a CRD upgrade that doesn''t cause data loss'
    counts: 1
    details:

    • count: 1
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:345
Unexpected error:
    <*errors.errorString | 0xc0001f6290>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:495
    meandurationsec: 320.606224
    skippedtests:
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should have created the expected
    prometheus objects    '
    counts: 1
    details: []
    meandurationsec: 22.078991
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should install the operator
    successfully    '
    counts: 1
    details: []
    meandurationsec: 9.069911
  • classname: End-to-end
    name: 'Catalog image update'
    counts: 1
    details: []
    meandurationsec: 0.02376
  • classname: End-to-end
    name: 'Subscription updates existing install plan'
    counts: 1
    details: []
    meandurationsec: 0.021337

exdx
exdx reviewed Oct 28, 2020
View reviewed changes
@exdx
Copy link
Member

exdx commented Oct 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@benluddy
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, harishsurf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@of-deploy-bot
Copy link

This PR failed 1 out of 1 times with 4 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
failedtestcount: 1
flaketestcount: 4
skippedtestcount: 4
flaketests:

  • classname: End-to-end
    name: 'Install Plan with CSVs across multiple catalog sources'
    counts: 3
    details:

    • count: 3
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:49
Resource does not match expected value:   &v1alpha1.InstallPlan{
  	TypeMeta: {},
  	ObjectMeta: v1.ObjectMeta{
  		... // 3 identical fields
  		SelfLink:                   "/apis/operators.coreos.com/v1alpha1/namespaces/operators/install"...,
  		UID:                        "de48a569-e4f3-4097-9cd2-2d5f546ce765",
- 		ResourceVersion:            "10524",
+ 		ResourceVersion:            "10528",
  		Generation:                 1,
  		CreationTimestamp:          {Time: s"2020-10-28 20:38:56 +0000 UTC"},
  		DeletionTimestamp:          nil,
  		DeletionGracePeriodSeconds: nil,
  		Labels: map[string]string{
  			"operators.coreos.com/nginx-sk9zn.operators":    "",
+ 			"operators.coreos.com/nginxdep-2mvdt.operators": "",
  		},
  		Annotations:     nil,
  		OwnerReferences: {{APIVersion: "operators.coreos.com/v1alpha1", Kind: "Subscription", Name: "sub-nginx-gwlzc", UID: "cb8c0706-b706-4a60-91d1-268e1e0f549c", ...}},
  		... // 3 identical fields
  	},
  	Spec:   {ClusterServiceVersionNames: {"nginxdep-2mvdt-stable", "nginx-sk9zn-stable"}, Approval: "Automatic", Approved: true, Generation: 1},
  	Status: {Phase: "Complete", Conditions: {{Type: "Installed", Status: "True", LastUpdateTime: s"2020-10-28 20:38:59 +0000 UTC", LastTransitionTime: s"2020-10-28 20:38:59 +0000 UTC", ...}}, CatalogSources: {"mock-ocs-dependent-rjlxj", "mock-ocs-main-7v49x"}, Plan: {&{Resolving: "nginxdep-2mvdt-stable", Resource: {CatalogSource: "mock-ocs-dependent-rjlxj", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginx-sk9zn-stable", Resource: {CatalogSource: "mock-ocs-main-7v49x", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginxdep-2mvdt-stable", Resource: {CatalogSource: "mock-ocs-dependent-rjlxj", CatalogSourceNamespace: "operators", Group: "apiextensions.k8s.io", Version: "v1beta1", ...}, Status: "Present"}, &{Resolving: "nginxdep-2mvdt-stable", Resource: {CatalogSource: "mock-ocs-dependent-rjlxj", CatalogSourceNamespace: "operators", Group: "operators.coreos.com", Version: "v1alpha1", ...}, Status: "Present"}}, ...},
  }

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:2792
    meandurationsec: 187.68717933333335
  • classname: End-to-end
    name: 'Install Plan creation with pre existing CRD owners PreExistingCRDOwnerIsReplaced'
    counts: 2
    details:

    • count: 2
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:329

	Error Trace:	installplan_e2e_test.go:438
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	timed out waiting for the condition

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
    meandurationsec: 324.337796
  • classname: End-to-end
    name: 'CSV update with owned API service'
    counts: 1
    details:

    • count: 1
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:1069

	Error Trace:	csv_e2e_test.go:1231
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	services "hat-serverjtdcz-service" not found
	Messages:   	error getting expected Service

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
    meandurationsec: 13.078551
  • classname: End-to-end
    name: 'Subscription creation in case of transferring providedAPIs'
    counts: 1
    details:

    • count: 1
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:1844

	Error Trace:	subscription_e2e_test.go:1921
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	clusterserviceversions.operators.coreos.com "nginx-a" not found

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
    meandurationsec: 18.647699
    skippedtests:
  • classname: End-to-end
    name: 'Catalog image update'
    counts: 1
    details: []
    meandurationsec: 0.036932
  • classname: End-to-end
    name: 'Subscription updates existing install plan'
    counts: 1
    details: []
    meandurationsec: 0.073781
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should install the operator
    successfully    '
    counts: 1
    details: []
    meandurationsec: 15.070329
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should have created the expected
    prometheus objects    '
    counts: 1
    details: []
    meandurationsec: 48.381704

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 684ef55 into operator-framework:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bowenislandsong Bowenislandsong Bowenislandsong left review comments

@exdx exdx exdx left review comments

@benluddy benluddy benluddy requested changes

@anik120 anik120 Awaiting requested review from anik120

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@harishsurf @of-deploy-bot @openshift-ci-robot @exdx @benluddy @openshift-bot @Bowenislandsong @openshift-merge-robot