[release-4.2] Bug 1836447: Generation bug #1526

openshift-cherrypick-robot · 2020-05-15T22:15:40Z

This is an automated cherry-pick of #1485

/assign ecordell

Problem: If an operator is being upgraded that provides a required API whose GVK has not changed since the previous version of the operator and uses a skipRange instead of the Spec.Replaces field, OLM will: * Add the new operator to the generation, and marking the APIs it provides as "present". * Remove the old operator from the generation, marking the APIs it provides as "absent", despite being provided by the new version of the operator. * Attempt to resolve the "missing" APIs, overwriting the new version of the operator with a copy that does not have its Spec.Replaces field set. This causes OLM to fail the upgrade, where the old operator's CSV will not be replaced and the new operators CSV will run into an intercepting API Provider issue. Solution: Update OLM to remove the old operator from the current generation before adding the new operator to the generation.

Problem: In an upgrade where v1 of Operator A provides an API and v1 of Operator B depends on the API, where the ownership of the API is transferred from Operator A to Operator B during the upgrade, OLM may run into a situation where Operator B is updated first. This causes OLM to fail to calculate the generation because multiple operator provide the same API. Solution: Add and remove updates as a set to prevent the situation described above.

openshift-ci-robot · 2020-05-15T22:15:48Z

@openshift-cherrypick-robot: Bugzilla bug 1827822 has been cloned as Bugzilla bug 1836447. Retitling PR to link against new bug.
/retitle [release-4.2] Bug 1836447: Generation bug 4.3

In response to this:

[release-4.2] Bug 1827822: Generation bug 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-15T22:15:57Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1836447, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.2.z) matches configured target release for branch (4.2.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1827822 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1827822 targets the "4.3.z" release, which is one of the valid target releases: 4.3.0, 4.3.z
bug has dependents

In response to this:

[release-4.2] Bug 1836447: Generation bug 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2020-05-15T22:16:57Z

/lgtm
/approve

openshift-ci-robot · 2020-05-15T22:17:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-16T23:56:14Z

/retest