Skip to content

Bug 1828550: add check for storage version changes when installing CRDs #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

Bug 1828550: add check for storage version changes when installing CRDs #1535

merged 1 commit into from
May 29, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented May 20, 2020

Description of the change:
Minimal bugfix to avoid potential dataloss when upgrading CRDs. Additional work in this area will be done as part of the CRD epic in the upcoming release.

Related to #1529 #1504

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx requested a review from ecordell May 20, 2020 19:39
@openshift-ci-robot
Copy link
Collaborator

@exdx: This pull request references Bugzilla bug 1828550, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828550: add check for storage version changes when installing CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 20, 2020
ecordell
ecordell reviewed May 20, 2020
View reviewed changes
@exdx exdx force-pushed the fix/block-storage-version-crd branch from 1e6264b to aef073d Compare May 26, 2020 18:33
@exdx exdx requested a review from ecordell May 26, 2020 18:33
ecordell
ecordell reviewed May 26, 2020
View reviewed changes
dinhxuanvu
dinhxuanvu previously requested changes May 26, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

@exdx
Copy link
Member Author

exdx commented May 27, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 27, 2020
@openshift-ci-robot
Copy link
Collaborator

@exdx: This pull request references Bugzilla bug 1828550, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 27, 2020
benluddy
benluddy reviewed May 27, 2020
View reviewed changes
@exdx exdx force-pushed the fix/block-storage-version-crd branch from aef073d to bf1706d Compare May 27, 2020 15:55
@exdx exdx requested review from ecordell, dinhxuanvu and benluddy May 27, 2020 15:55
@exdx exdx force-pushed the fix/block-storage-version-crd branch 2 times, most recently from 92aac5f to de07714 Compare May 27, 2020 19:09
@exdx
Copy link
Member Author

exdx commented May 27, 2020

I think this is close, just need to figure out how to get the second e2e test to pass.

@exdx exdx force-pushed the fix/block-storage-version-crd branch 2 times, most recently from 396861b to fb3dd62 Compare May 28, 2020 00:13
@exdx exdx force-pushed the fix/block-storage-version-crd branch from fb3dd62 to f654c7e Compare May 28, 2020 14:32
@exdx
fix: add check for storage version changes when installing CRDs. This
d7102ed 
prevents data loss when a CRD is upgraded and no longer supports
existing stored versions of CRs on the cluster.
@exdx exdx force-pushed the fix/block-storage-version-crd branch from f654c7e to d7102ed Compare May 28, 2020 14:45
@exdx
Copy link
Member Author

exdx commented May 28, 2020

both e2e tests now pass locally -- once quay is back up e2e should pass, assuming no existing e2e tests do unsafe storage version upgrades with their CRDs.

@dinhxuanvu
Copy link
Member

/retest

dinhxuanvu
dinhxuanvu reviewed May 28, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@ecordell
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dinhxuanvu
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dinhxuanvu
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0bcd497 into operator-framework:master May 29, 2020
@openshift-ci-robot
Copy link
Collaborator

@exdx: Some pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1535. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1828550: add check for storage version changes when installing CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@njhale njhale Awaiting requested review from njhale

@ecordell ecordell Awaiting requested review from ecordell

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@exdx @openshift-ci-robot @dinhxuanvu @ecordell @openshift-bot @benluddy @openshift-merge-robot