Bug 1841171: Update PkgManifest upon catsrc update #1556

Bowenislandsong · 2020-05-28T14:51:27Z

The catsrc update sync triggered by the informer does not update pkgmanifest. This commit adds an update mechanism.

Description of the change:

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci-robot · 2020-05-28T14:51:30Z

@Bowenislandsong: This pull request references Bugzilla bug 1841171, which is invalid:

expected dependent Bugzilla bug 1823714 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1841171: Update PkgManifest upon catsrc update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bowenislandsong · 2020-05-28T14:52:21Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-05-28T14:52:22Z

@Bowenislandsong: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bowenislandsong · 2020-06-02T02:45:04Z

/bugzilla refresh

openshift-ci-robot · 2020-06-02T02:45:11Z

@Bowenislandsong: This pull request references Bugzilla bug 1841171, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1823714 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1823714 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bowenislandsong · 2020-06-02T02:45:22Z

/retest

Bowenislandsong · 2020-06-02T02:46:12Z

/cc @kevinrizza @dinhxuanvu could you guys help with this backport. Thanks

Bowenislandsong · 2020-06-02T12:31:52Z

/retest

Bowenislandsong · 2020-06-02T14:32:08Z

/retest

kevinrizza · 2020-06-02T14:35:15Z

/approve
lgtm

Bowenislandsong · 2020-06-02T20:42:46Z

/retest

njhale

Looks good!

Side Note: I do think there may be some issue detecting connection state change in the source store. In theory, we shouldn't need this patch because any catalog update we care about should result in a connection state change, which should trigger a cache refresh.

Orthogonal Note: It looks like we can leak goroutines when the address changes. One way to fix this would be to stop any existing source on p.sources.Add with a non-matching address first.

njhale · 2020-06-02T23:22:57Z

test/e2e/packagemanifest_e2e_test.go

+	)
+	BeforeEach(func() {
+		crc = newCRClient()
+		pmc = newPMClient()


Whoops -- these calls are missing some arguments!

openshift-bot · 2020-06-02T23:24:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-03T00:16:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

njhale · 2020-06-03T01:14:48Z

/hold

just until the test is fixed.

Bowenislandsong · 2020-06-03T12:51:54Z

/test e2e-aws-olm

openshift-ci-robot · 2020-06-03T15:32:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bowenislandsong, kevinrizza, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kevinrizza,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The catsrc update sync triggered by the informer does not update pkgmanifest. This commit adds an update mechanism.

Bowenislandsong · 2020-06-03T17:57:20Z

/retest

exdx · 2020-06-03T19:51:34Z

/lgtm

Bowenislandsong · 2020-06-03T21:36:37Z

/hold cancel
Test fixed

openshift-bot · 2020-06-11T05:26:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-11T06:05:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-06-11T06:29:48Z

@Bowenislandsong: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1556. Bugzilla bug 1841171 has been moved to the MODIFIED state.

In response to this:

Bug 1841171: Update PkgManifest upon catsrc update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-06-11T06:29:54Z

@Bowenislandsong: new pull request created: #1581

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 28, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 28, 2020

openshift-ci-robot requested review from ecordell and exdx May 28, 2020 14:51

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 2, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020

njhale approved these changes Jun 2, 2020

View reviewed changes

openshift-ci-robot assigned njhale Jun 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020

njhale reviewed Jun 2, 2020

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020

Bowenislandsong force-pushed the bug/updatepkgManifestDisplayName-4.4 branch from 91ef628 to b318729 Compare June 3, 2020 15:32

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020

Update PkgManifest upon catsrc update

f7c8fae

The catsrc update sync triggered by the informer does not update pkgmanifest. This commit adds an update mechanism.

Bowenislandsong force-pushed the bug/updatepkgManifestDisplayName-4.4 branch from b318729 to f7c8fae Compare June 3, 2020 15:34

openshift-ci-robot assigned exdx Jun 3, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020

knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 10, 2020

openshift-merge-robot merged commit 33671eb into operator-framework:release-4.4 Jun 11, 2020

openshift-cherrypick-robot mentioned this pull request Jun 11, 2020

[release-4.3] Bug 1846220: Update PkgManifest upon catsrc update #1581

Merged

Bug 1841171: Update PkgManifest upon catsrc update #1556

Bug 1841171: Update PkgManifest upon catsrc update #1556

Uh oh!

Conversation

Bowenislandsong commented May 28, 2020

Uh oh!

openshift-ci-robot commented May 28, 2020

Uh oh!

Bowenislandsong commented May 28, 2020

Uh oh!

openshift-cherrypick-robot commented May 28, 2020

Uh oh!

Bowenislandsong commented Jun 2, 2020

Uh oh!

openshift-ci-robot commented Jun 2, 2020

Uh oh!

Bowenislandsong commented Jun 2, 2020

Uh oh!

Bowenislandsong commented Jun 2, 2020

Uh oh!

Bowenislandsong commented Jun 2, 2020

Uh oh!

Bowenislandsong commented Jun 2, 2020

Uh oh!

kevinrizza commented Jun 2, 2020

Uh oh!

Bowenislandsong commented Jun 2, 2020

Uh oh!

njhale left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

njhale Jun 2, 2020

Choose a reason for hiding this comment

Uh oh!

Bowenislandsong Jun 3, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

openshift-bot commented Jun 3, 2020

Uh oh!

njhale commented Jun 3, 2020

Uh oh!

Bowenislandsong commented Jun 3, 2020

Uh oh!

openshift-ci-robot commented Jun 3, 2020

Uh oh!

Bowenislandsong commented Jun 3, 2020

Uh oh!

exdx commented Jun 3, 2020

Uh oh!

Bowenislandsong commented Jun 3, 2020

Uh oh!

openshift-bot commented Jun 11, 2020

Uh oh!

openshift-bot commented Jun 11, 2020

Uh oh!

openshift-ci-robot commented Jun 11, 2020

Uh oh!

openshift-cherrypick-robot commented Jun 11, 2020

Uh oh!

Uh oh!

njhale left a comment •

edited

Loading