feat(resolver): don't build new clauses for weights #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into operator-framework:master from ecordell:weights

Jun 3, 2020

Member

ecordell commented Jun 2, 2020 •

edited

Loading

Description of the change:
This builds a sorting network with multiple entries to signal weight, instead of explicit weight literals and constraints on them.

For example:

Prior to this change:

Installable x of weight 3 and y of weight 2 would give:

(x, w0, w1, w2, y, wy0, wy1) literals (cardinality is minimized)
(x -> w0, x -> w1, x-> w2, y -> wy0, y -> wy1) constraints

so the cardinality of picking x is 3 and the cardinality of picking y is 2

Benchmarks:

BenchmarkCompileDict-12    	      18	  55723828 ns/op
BenchmarkDictSolve-12      	       1	1656260078 ns/op
PASS

After this change:

Installable x of weight 3 and y of weight 2 would give:

(x, x, x, y, y) literals (cardinality is minimized)
no constraints

so the cardinality of picking x is 3 and the cardinality of picking y is 2

Benchmarks:

BenchmarkCompileDict-12    	   12636	     90925 ns/op
BenchmarkDictSolve-12      	      22	  52780348 ns/op
PASS

Motivation for the change:
Speed up resolution.

Source: page 13 of Translating Pseudo-Boolean Constraints into SAT

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

Collaborator

openshift-ci-robot commented Jun 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot requested review from Bowenislandsong and gallettilance

June 2, 2020 13:27

openshift-ci-robot added the approved label

ecordell force-pushed the weights branch from f3a6ec3 to 6a0bef7 Compare

June 2, 2020 13:42


          feat(resolver): don't build new clauses for weights

0f6f57f

ecordell force-pushed the weights branch from 6a0bef7 to 0f6f57f Compare

June 2, 2020 13:48

Contributor

benluddy commented Jun 2, 2020

/lgtm

openshift-ci-robot assigned benluddy

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 0aaab9d into operator-framework:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels