Bug 1843703: Deleting a CSV removes related CSV metrics #1569

harishsurf · 2020-06-03T21:35:33Z

Description of the change:

Backport PR #1525 bug fix to 4.3

Signed-off-by: Harish [email protected]

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci-robot · 2020-06-03T21:35:36Z

@harishsurf: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1819308 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2020-06-03T21:44:33Z

/bugzilla refresh

openshift-ci-robot · 2020-06-03T21:44:36Z

@ecordell: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/metrics/metrics.go

awgreene

/approve

awgreene · 2020-06-04T12:48:46Z

/lgtm

awgreene · 2020-06-04T12:49:12Z

/retest

openshift-bot · 2020-06-05T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-05T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-06T01:00:51Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-06T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-07T01:00:40Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-07T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-08T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-08T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-09T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-09T01:00:59Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-10T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-10T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-11T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-11T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-12T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-12T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-13T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-20T01:08:50Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-21T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-21T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-22T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-22T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is invalid:

expected dependent Bugzilla bug 1843678 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-23T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-23T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1843703, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1843678 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1843678 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2020-06-23T14:20:19Z

/approve

Problem: Bug 1843703: When creating a CSV fails, deleting it did not clear the CSV metrics. So when the same CSV was created again and allowed to succeed, the olm pod still retained the old CSV metrics Solution: Deleting a CSV will now clear its related metrics from the olm pod Signed-off-by: Harish <[email protected]>

ecordell

/approve

openshift-ci-robot · 2020-06-23T14:35:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell, harishsurf, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ecordell · 2020-06-23T14:36:05Z

/lgtm

openshift-bot · 2020-06-23T14:52:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-25T13:51:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-25T16:52:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-25T17:57:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-25T19:02:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-25T19:28:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-25T21:51:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-06-26T02:08:27Z

@harishsurf: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1569. Bugzilla bug 1843703 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 3, 2020

openshift-ci-robot requested review from jpeeler and njhale June 3, 2020 21:35

awgreene reviewed Jun 4, 2020

View reviewed changes

pkg/metrics/metrics.go Outdated Show resolved Hide resolved

awgreene approved these changes Jun 4, 2020

View reviewed changes

openshift-ci-robot assigned awgreene Jun 4, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 23, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 23, 2020

harishsurf force-pushed the csv-abnormal-4.3 branch from 02dfe1c to d58967c Compare June 23, 2020 14:33

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020

ecordell approved these changes Jun 23, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020

openshift-ci-robot assigned ecordell Jun 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020

shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2020

openshift-merge-robot merged commit b57391e into operator-framework:release-4.3 Jun 26, 2020

harishsurf deleted the csv-abnormal-4.3 branch July 7, 2020 16:50

Bug 1843703: Deleting a CSV removes related CSV metrics #1569

Bug 1843703: Deleting a CSV removes related CSV metrics #1569

Uh oh!

Conversation

harishsurf commented Jun 3, 2020

Uh oh!

openshift-ci-robot commented Jun 3, 2020

Uh oh!

ecordell commented Jun 3, 2020

Uh oh!

openshift-ci-robot commented Jun 3, 2020

Uh oh!

Uh oh!

awgreene left a comment

Choose a reason for hiding this comment

Uh oh!

awgreene commented Jun 4, 2020

Uh oh!

awgreene commented Jun 4, 2020

Uh oh!

openshift-bot commented Jun 5, 2020

Uh oh!

openshift-ci-robot commented Jun 5, 2020

Uh oh!

openshift-bot commented Jun 6, 2020

Uh oh!

openshift-ci-robot commented Jun 6, 2020

Uh oh!

openshift-bot commented Jun 7, 2020

Uh oh!

openshift-ci-robot commented Jun 7, 2020

Uh oh!

openshift-bot commented Jun 8, 2020

Uh oh!

openshift-ci-robot commented Jun 8, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 10, 2020

Uh oh!

openshift-ci-robot commented Jun 10, 2020

Uh oh!

openshift-bot commented Jun 11, 2020

Uh oh!

openshift-ci-robot commented Jun 11, 2020

Uh oh!

openshift-bot commented Jun 12, 2020

Uh oh!

openshift-ci-robot commented Jun 12, 2020

Uh oh!

openshift-bot commented Jun 13, 2020

Uh oh!

openshift-ci-robot commented Jun 20, 2020

Uh oh!

openshift-bot commented Jun 21, 2020

Uh oh!

openshift-ci-robot commented Jun 21, 2020

Uh oh!

openshift-bot commented Jun 22, 2020

Uh oh!

openshift-ci-robot commented Jun 22, 2020

Uh oh!

openshift-bot commented Jun 23, 2020

Uh oh!

openshift-ci-robot commented Jun 23, 2020

Uh oh!

kevinrizza commented Jun 23, 2020

Uh oh!

ecordell left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jun 23, 2020

Uh oh!

ecordell commented Jun 23, 2020

Uh oh!

openshift-bot commented Jun 23, 2020

Uh oh!

openshift-bot commented Jun 25, 2020