Skip to content

Add flake analyzer periodics #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Bowenislandsong
Copy link
Member

@Bowenislandsong Bowenislandsong commented Jul 16, 2020

This commit introduces the flake analyzer to OLM to create weekly flake reports for the past and previous 7 days. The result will be uploaded to GITHUB as artifacts.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@Bowenislandsong
Copy link
Member Author

/hold
Wait for a success run

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@Bowenislandsong
Copy link
Member Author

Bowenislandsong commented Jul 16, 2020

/cc @ecordell
Waiting for personal access token named FLAKE_BOT_SECRET

@Bowenislandsong Bowenislandsong force-pushed the feat/add-flake-analyzer branch 2 times, most recently from 1a86433 to b506c5c Compare July 16, 2020 21:01
@Bowenislandsong
Copy link
Member Author

No personal access token needed. weekly report test run was successful and availble at https://github.com/operator-framework/operator-lifecycle-manager/runs/879483265?check_suite_focus=true

@Bowenislandsong
Copy link
Member Author

/hold cancel
Periodic report generated https://github.com/operator-framework/operator-lifecycle-manager/actions/runs/171922622
This periodic report will be available per day which daily, and weekly reports on each run.

The current implementation can not accommodate PR commenting due to token issue. When the analyzer becomes a bot, we will be able to comment.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@Bowenislandsong Bowenislandsong force-pushed the feat/add-flake-analyzer branch 2 times, most recently from a500dbe to 8dda9ad Compare July 16, 2020 21:52
@Bowenislandsong
Copy link
Member Author

/retest

3 similar comments
@Bowenislandsong
Copy link
Member Author

/retest

@Bowenislandsong
Copy link
Member Author

/retest

@Bowenislandsong
Copy link
Member Author

/retest

@Bowenislandsong
Copy link
Member Author

/hold
Adding comment abaility

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@Bowenislandsong Bowenislandsong force-pushed the feat/add-flake-analyzer branch from 89f4096 to 1da2805 Compare July 17, 2020 16:25
This commit introduces the flake analyzer to OLM to create weekly flake reports for the past and previous 7 days plus today. The result will be uploaded to GITHUB as artifacts.
@Bowenislandsong Bowenislandsong force-pushed the feat/add-flake-analyzer branch 7 times, most recently from 0576004 to 1e8e896 Compare July 17, 2020 22:53
@Bowenislandsong
Copy link
Member Author

/hold cancel
comment ability is avaliable via any existing workflow add ons. Bot with a server or periodics are the only options.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@Bowenislandsong
Copy link
Member Author

The PR failed tests for 0 times with 0 individual failed tests and 0 skipped tests.

totaltestcount: 0
flaketestcount: 0
skippedtestcount: 0
flaketests: []
skippedtests: []

@Bowenislandsong
Copy link
Member Author

Bowenislandsong commented Jul 18, 2020

The PR failed tests for 1 times with 1 individual failed tests and 5 skipped tests.

totaltestcount: 1
flaketestcount: 1
skippedtestcount: 5
flaketests:

  • classname: End-to-end
    name: Subscription creation manual approval
    counts: 1
    details:
    • count: 1
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:178
      
      	Error Trace:	subscription_e2e_test.go:185
      	            				runner.go:113
      	            				runner.go:64
      	            				it_node.go:26
      	            				spec.go:215
      	            				spec.go:138
      	            				spec_runner.go:200
      	            				spec_runner.go:170
      	            				spec_runner.go:66
      	            				suite.go:62
      	            				ginkgo_dsl.go:226
      	            				ginkgo_dsl.go:214
      	            				e2e_test.go:54
      	Error:      	Received unexpected error:
      	            	E2E bug detected: configmaps "mock-ocs" already exists
      
      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
      
    meandurationsec: 0.040457
    skippedtests:
  • classname: End-to-end
    name: Subscriptions create required objects from Catalogs Given a Namespace when
    a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should have created the expected
    prometheus objects
    counts: 1
    details: []
    meandurationsec: 2.16539
  • classname: End-to-end
    name: Subscriptions create required objects from Catalogs Given a Namespace when
    a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should install the operator
    successfully
    counts: 1
    details: []
    meandurationsec: 2.926843
  • classname: End-to-end
    name: Subscription updates existing install plan
    counts: 1
    details: []
    meandurationsec: 0.095173
  • classname: End-to-end
    name: Installing bundles with new object types when a bundle with a pdb, priorityclass,
    and VPA object is installed should create the additional bundle objects
    counts: 1
    details: []
    meandurationsec: 0
  • classname: End-to-end
    name: Catalog image update
    counts: 1
    details: []
    meandurationsec: 0.014702

@Bowenislandsong
Copy link
Member Author

/retest

@Bowenislandsong
Copy link
Member Author

This PR failed tests for 1 times with 1 individual failed tests and 5 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
flaketestcount: 1
skippedtestcount: 5
flaketests:

  • classname: End-to-end
    name: 'Install Plan with CRD schema change Test all existing versions are present,
    different (backwards compatible) schema
    '
    counts: 1
    details:
    • count: 1
      error: |4-

      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:43
      
      	Error Trace:	installplan_e2e_test.go:812
      	            				value.go:460
      	            				value.go:321
      	            				table_entry.go:37
      	            				runner.go:113
      	            				runner.go:64
      	            				it_node.go:26
      	            				spec.go:215
      	            				spec.go:138
      	            				spec_runner.go:200
      	            				spec_runner.go:170
      	            				spec_runner.go:66
      	            				suite.go:62
      	            				ginkgo_dsl.go:226
      	            				ginkgo_dsl.go:214
      	            				e2e_test.go:54
      	Error:      	Received unexpected error:
      	            	etcdserver: request timed out
      
      /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
      
    meandurationsec: 25.831612
    skippedtests:
  • classname: End-to-end
    name: 'Subscription updates existing install plan'
    counts: 1
    details: []
    meandurationsec: 0.023219
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should install the operator
    successfully
    '
    counts: 1
    details: []
    meandurationsec: 2.196919
  • classname: End-to-end
    name: 'Subscriptions create required objects from Catalogs Given a Namespace
    when a CatalogSource is created with a bundle that contains prometheus objects
    creating a subscription using the CatalogSource should have created the expected
    prometheus objects
    '
    counts: 1
    details: []
    meandurationsec: 2.215525
  • classname: End-to-end
    name: 'Installing bundles with new object types when a bundle with a pdb, priorityclass,
    and VPA object is installed should create the additional bundle objects
    '
    counts: 1
    details: []
    meandurationsec: 0
  • classname: End-to-end
    name: 'Catalog image update'
    counts: 1
    details: []
    meandurationsec: 0.023103

@Bowenislandsong
Copy link
Member Author

/retest

@Bowenislandsong Bowenislandsong changed the title Add flake analyzer Add flake analyzer periodics Jul 20, 2020
@benluddy
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, Bowenislandsong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Bowenislandsong
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit cc2112c into operator-framework:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants