Skip to content

fix: explicitly delete collection of catalog source pods in grpc e2e test #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix: explicitly delete collection of catalog source pods in grpc e2e test #1656

merged 1 commit into from
Jul 22, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented Jul 20, 2020

Description of the change:

Motivation for the change:

 • Failure [40.912 seconds]
Catalog
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:33
  delete gRPC registry pod triggers recreation [It]
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:614

  
  	Error Trace:	catalog_e2e_test.go:679
  	            				runner.go:113
  	            				runner.go:64
  	            				it_node.go:26
  	            				spec.go:215
  	            				spec.go:138
  	            				spec_runner.go:200
  	            				spec_runner.go:170
  	            				spec_runner.go:66
  	            				suite.go:62
  	            				ginkgo_dsl.go:226
  	            				ginkgo_dsl.go:214
  	            				e2e_test.go:54
  	Error:      	Received unexpected error:
  	            	pods "catalog-ktxs2-6c2hs" not found

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx requested review from ecordell and njhale July 20, 2020 20:02
awgreene
awgreene approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@exdx
Copy link
Member Author

exdx commented Jul 21, 2020

/retest

benluddy
benluddy reviewed Jul 21, 2020
View reviewed changes
@exdx exdx force-pushed the fix/delete-grpc-e2e-fix branch from b83bfe5 to 1542547 Compare July 21, 2020 17:06
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@exdx exdx requested review from awgreene and benluddy July 21, 2020 17:06
@exdx
Copy link
Member Author

exdx commented Jul 21, 2020

Also removed explicit cleanup from this test since this is now covered by the updated AfterEach cleanup that runs after every It spec in this e2e suite

@benluddy
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
awgreene
awgreene approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, benluddy, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@exdx
Copy link
Member Author

exdx commented Jul 22, 2020

/test e2e-gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8036f28 into operator-framework:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene awgreene approved these changes

@ecordell ecordell Awaiting requested review from ecordell

@njhale njhale Awaiting requested review from njhale

@anik120 anik120 Awaiting requested review from anik120

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@exdx @benluddy @openshift-ci-robot @ecordell @openshift-bot @awgreene @openshift-merge-robot