Bug 1859717: Fix validate CRD compatibility check and deprecated CRD test case

[dinhxuanvu]

1. Fix validate CRD compatibility
   Should only run against served versions instead the non-served
   versions (! operator error)
2. Clean up the deprecated CRD versions test:
   Using standup catsrc upgrade and get rid of unnecessary subscription
   deletion.

Signed-off-by: Vu Dinh [email protected]

Description of the change:

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[Bowenislandsong]

This PR failed tests for 1 times with 1 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
flaketestcount: 1
skippedtestcount: 4
flaketests:

• classname: End-to-end
  name: 'Install Plan with CRD schema change Test missing existing versions in
  new CRD'
  counts: 1
  details:

  • count: 1
    error: |4-

    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:43
    
    	Error Trace:	installplan_e2e_test.go:849
    	            				value.go:460
    	            				value.go:321
    	            				table_entry.go:37
    	            				runner.go:113
    	            				runner.go:64
    	            				it_node.go:26
    	            				spec.go:215
    	            				spec.go:138
    	            				spec_runner.go:200
    	            				spec_runner.go:170
    	            				spec_runner.go:66
    	            				suite.go:62
    	            				ginkgo_dsl.go:226
    	            				ginkgo_dsl.go:214
    	            				e2e_test.go:54
    	Error:      	Received unexpected error:
    	            	clusterserviceversions.operators.coreos.com "nginx-bc9nv-beta" not found
    
    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
    

  meandurationsec: 26.277321
  skippedtests:
• classname: End-to-end
  name: 'Subscription updates existing install plan'
  counts: 1
  details: []
  meandurationsec: 0.37271
• classname: End-to-end
  name: 'Subscriptions create required objects from Catalogs Given a Namespace
  when a CatalogSource is created with a bundle that contains prometheus objects
  creating a subscription using the CatalogSource should install the operator
  successfully'
  counts: 1
  details: []
  meandurationsec: 2.119683
• classname: End-to-end
  name: 'Catalog image update'
  counts: 1
  details: []
  meandurationsec: 0.487384
• classname: End-to-end
  name: 'Subscriptions create required objects from Catalogs Given a Namespace
  when a CatalogSource is created with a bundle that contains prometheus objects
  creating a subscription using the CatalogSource should have created the expected
  prometheus objects'
  counts: 1
  details: []
  meandurationsec: 2.165053

[dinhxuanvu]

/retest

[Bowenislandsong]

This PR failed tests for 1 times with 1 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
flaketestcount: 1
skippedtestcount: 4
flaketests:

• classname: End-to-end
  name: 'CSV emits CSV requirement events'
  counts: 1
  details:

  • count: 1
    error: |4-

    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:2667
    Timed out after 60.000s.
    Expected success, but got an error:
        <*errors.StatusError | 0xc001208000>: {
            ErrStatus: {
                TypeMeta: {Kind: "", APIVersion: ""},
                ListMeta: {
                    SelfLink: "",
                    ResourceVersion: "",
                    Continue: "",
                    RemainingItemCount: nil,
                },
                Status: "Failure",
                Message: "Operation cannot be fulfilled on clusterserviceversions.operators.coreos.com \"csv-9swqs\": the object has been modified; please apply your changes to the latest version and try again",
                Reason: "Conflict",
                Details: {
                    Name: "csv-9swqs",
                    Group: "operators.coreos.com",
                    Kind: "clusterserviceversions",
                    UID: "",
                    Causes: nil,
                    RetryAfterSeconds: 0,
                },
                Code: 409,
            },
        }
        Operation cannot be fulfilled on clusterserviceversions.operators.coreos.com "csv-9swqs": the object has been modified; please apply your changes to the latest version and try again
    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:2746
    

  meandurationsec: 64.845177
  skippedtests:
• classname: End-to-end
  name: 'Subscriptions create required objects from Catalogs Given a Namespace
  when a CatalogSource is created with a bundle that contains prometheus objects
  creating a subscription using the CatalogSource should have created the expected
  prometheus objects'
  counts: 1
  details: []
  meandurationsec: 1.13717
• classname: End-to-end
  name: 'Subscriptions create required objects from Catalogs Given a Namespace
  when a CatalogSource is created with a bundle that contains prometheus objects
  creating a subscription using the CatalogSource should install the operator
  successfully'
  counts: 1
  details: []
  meandurationsec: 2.106923
• classname: End-to-end
  name: 'Catalog image update'
  counts: 1
  details: []
  meandurationsec: 0.112922
• classname: End-to-end
  name: 'Subscription updates existing install plan'
  counts: 1
  details: []
  meandurationsec: 0.780872

[dinhxuanvu]

/retest

[dinhxuanvu]

/retest

[exdx]

/lgtm

[dinhxuanvu]

/retest

[kevinrizza]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dinhxuanvu: All pull requests linked via external trackers have merged: . Bugzilla bug 1859717 has been moved to the MODIFIED state.

In response to this:

Bug 1859717: Fix validate CRD compatibility check and deprecated CRD test case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[njhale]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@njhale: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between operator-framework:release-4.5 and openshift-cherrypick-robot:cherry-pick-1659-to-release-4.5"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.