Skip to content

feat(resolver): filtering deprecated bundles in resolver #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2020
Merged

feat(resolver): filtering deprecated bundles in resolver #1699

merged 2 commits into from
Aug 5, 2020

Conversation

dinhxuanvu
Copy link
Member

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@dinhxuanvu dinhxuanvu requested review from ecordell and benluddy July 31, 2020 22:32
@dinhxuanvu dinhxuanvu mentioned this pull request Jul 31, 2020
Closed
5 tasks
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@ecordell
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu added the area/dependency Issues or PRs related to dependency changes label Aug 1, 2020
@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2020
@ecordell
Copy link
Member

ecordell commented Aug 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2020
@dinhxuanvu
Copy link
Member Author

/retest

2 similar comments
@Bowenislandsong
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu closed this Aug 2, 2020
@dinhxuanvu dinhxuanvu reopened this Aug 2, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dinhxuanvu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@benluddy
Copy link
Contributor

benluddy commented Aug 3, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@benluddy
Copy link
Contributor

benluddy commented Aug 3, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

gallettilance and others added 2 commits August 4, 2020 14:17
@gallettilance @dinhxuanvu
feat(resolver): filtering deprecated bundles in resolver
9a58660
@dinhxuanvu
Vendor registry 1.13.6 and fix unit test
1ca55ff 
1. Vendor the newest release of registry to avoid conflict with
another PR that may get merged first.
2. Fix unit test

Signed-off-by: Vu Dinh <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@Bowenislandsong
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 163608d into operator-framework:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell Awaiting requested review from ecordell

@benluddy benluddy Awaiting requested review from benluddy

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@ecordell ecordell

@kevinrizza kevinrizza

@Bowenislandsong Bowenislandsong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dinhxuanvu @ecordell @openshift-ci-robot @Bowenislandsong @openshift-bot @benluddy @kevinrizza @openshift-merge-robot @gallettilance