Skip to content

test: patch existing CSV for a hotfix #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2021
Merged

test: patch existing CSV for a hotfix #1817

merged 1 commit into from
Mar 28, 2021

Conversation

jeyaramashok
Copy link
Contributor

Description of the change:

This is a e2e test case for hot fixing a CSV. In this scenario an existing CSV is patched directly to update the deployment spec.

Motivation for the change:

hot fix scenario described in #1774

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot
Copy link
Collaborator

Hi @jeyaramashok. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2020
@jeyaramashok jeyaramashok mentioned this pull request Oct 17, 2020
Closed
ankitathomas
ankitathomas approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 20, 2020
@jeyaramashok
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Collaborator

@jeyaramashok: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm a3cc46a link /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeyaramashok
Copy link
Contributor Author

/assign @kevinrizza

@ecordell
Copy link
Member

ecordell commented Dec 4, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@awgreene
Copy link
Member

/retest

awgreene
awgreene reviewed Jan 14, 2021
View reviewed changes
test/e2e/csv_e2e_test.go Outdated
Comment on lines 2776 to 2785
// Fetch the current csv
fetchedCSV, err := fetchCSV(crc, csv.Name, testNamespace, csvSucceededChecker)
require.NoError(GinkgoT(), err)

// Update csv with modified deployment spec
fetchedCSV.Spec.InstallStrategy.StrategySpec = strategyNew

// Update the current csv
_, err = crc.OperatorsV1alpha1().ClusterServiceVersions(testNamespace).Update(context.TODO(), fetchedCSV, metav1.UpdateOptions{})
require.NoError(GinkgoT(), err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this all be done in an Eventually() command? As it is, the update command may occasionally fail if another resource modifies the CSV before it is fetched.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed this msg, I have update to include eventually() block https://github.com/operator-framework/operator-lifecycle-manager/pull/1817/files#diff-e94bc9e5ebd2b6db20f851288184630432208a5a772cf0515935707ad3660799R3034

awgreene
awgreene requested changes Jan 14, 2021
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change request, looks good otherwise.

@exdx
Copy link
Member

exdx commented Jan 14, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@exdx
Copy link
Member

exdx commented Jan 14, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@dinhxuanvu
Copy link
Member

/test e2e-aws-olm

@timflannagan
Copy link
Member

/retest

timflannagan
timflannagan reviewed Mar 23, 2021
View reviewed changes
@jeyaramashok
test: patch existing CSV for a hotfix
286a63c 
This is a test for the hotfix scenario, where an existing CSV is patched directly to
update the deployment spec.

Ref: operator-framework#1774
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, ecordell, jeyaramashok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link
Member

/retest

@timflannagan
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a807a0d into operator-framework:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan left review comments

@awgreene awgreene awgreene requested changes

@ankitathomas ankitathomas ankitathomas approved these changes

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@kevinrizza kevinrizza

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.