[release-4.6] Bug 1892244: Set default, min, and max values on Webhook ports #1838

openshift-cherrypick-robot · 2020-10-28T09:51:35Z

This is an automated cherry-pick of #1835

/assign awgreene

Problem: Operator Authors can create CSVs that define Webhooks with containerPorts set outside the range of 1-65535, which prevents the ValidatingWebhookConfiguration or MutatingWebhookConfiguration from being created due to failed validation. Solution: Update the CSV's CRD Validation to include the proper min and max values for webhookDescription ContainerPort field. If the containerPort is not defined, default to 443.

openshift-ci-robot · 2020-10-28T09:51:46Z

@openshift-cherrypick-robot: Bugzilla bug 1891898 has been cloned as Bugzilla bug 1892244. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1892244: Set default, min, and max values on Webhook ports

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-28T09:51:53Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-10-28T15:00:04Z

/approve

dinhxuanvu

/lgtm

openshift-ci-robot · 2020-10-28T15:01:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

awgreene · 2020-10-28T15:09:20Z

/cherry-pick release-4.5

openshift-cherrypick-robot · 2020-10-28T15:09:21Z

@awgreene: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-29T01:00:50Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-29T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-30T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-30T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-10-30T14:27:18Z

/cherry-pick release-4.5

openshift-cherrypick-robot · 2020-10-30T14:27:19Z

@awgreene: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-31T01:04:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-31T01:04:17Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-01T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-01T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-02T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-02T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-03T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-04T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-04T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-05T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-05T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-06T01:00:53Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-06T01:00:56Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-07T01:00:53Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-07T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-08T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-08T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-09T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-09T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-10T01:00:50Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-10T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1892244, which is invalid:

expected dependent Bugzilla bug 1891898 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-11-10T20:06:42Z

/bugzilla refresh

openshift-ci-robot · 2020-11-10T20:06:48Z

@awgreene: This pull request references Bugzilla bug 1892244, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1891898 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1891898 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2020-11-11T07:12:09Z

/bugzilla cc-qa

openshift-ci-robot · 2020-11-11T07:12:15Z

@jianzhangbjz: This pull request references Bugzilla bug 1892244, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1891898 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1891898 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-11T07:12:16Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stale · 2021-01-10T07:47:11Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kevinrizza · 2021-02-01T18:22:51Z

Closing as the priority of this bz means it most likely will never be cherry picked.

openshift-ci-robot · 2021-02-01T18:22:58Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1892244. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned awgreene Oct 28, 2020

openshift-cherrypick-robot mentioned this pull request Oct 28, 2020

Bug 1891898: Set default, min, and max values on Webhook ports #1835

Merged

openshift-ci-robot requested review from benluddy and dinhxuanvu October 28, 2020 09:51

openshift-ci-robot changed the title ~~[release-4.6] Bug 1891898: Set default, min, and max values on Webhook ports~~ [release-4.6] Bug 1892244: Set default, min, and max values on Webhook ports Oct 28, 2020

openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 28, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 28, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020

dinhxuanvu approved these changes Oct 28, 2020

View reviewed changes

openshift-ci-robot assigned dinhxuanvu Oct 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 10, 2020

stale bot added the wontfix label Jan 10, 2021

openshift-ci-robot added triage/unresolved Indicates an issue that can not or will not be resolved. and removed wontfix labels Jan 10, 2021

benluddy removed the triage/unresolved Indicates an issue that can not or will not be resolved. label Jan 15, 2021

kevinrizza closed this Feb 1, 2021

[release-4.6] Bug 1892244: Set default, min, and max values on Webhook ports #1838

[release-4.6] Bug 1892244: Set default, min, and max values on Webhook ports #1838

Uh oh!

Conversation

openshift-cherrypick-robot commented Oct 28, 2020

Uh oh!

openshift-ci-robot commented Oct 28, 2020

Uh oh!

openshift-ci-robot commented Oct 28, 2020

Uh oh!

awgreene commented Oct 28, 2020

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 28, 2020

Uh oh!

awgreene commented Oct 28, 2020

Uh oh!

openshift-cherrypick-robot commented Oct 28, 2020

Uh oh!

openshift-bot commented Oct 29, 2020

Uh oh!

openshift-ci-robot commented Oct 29, 2020

Uh oh!

openshift-bot commented Oct 30, 2020

Uh oh!

openshift-ci-robot commented Oct 30, 2020

Uh oh!

awgreene commented Oct 30, 2020

Uh oh!

openshift-cherrypick-robot commented Oct 30, 2020

Uh oh!

openshift-bot commented Oct 31, 2020

Uh oh!

openshift-ci-robot commented Oct 31, 2020

Uh oh!

openshift-bot commented Nov 1, 2020

Uh oh!

openshift-ci-robot commented Nov 1, 2020

Uh oh!

openshift-bot commented Nov 2, 2020

Uh oh!

openshift-ci-robot commented Nov 2, 2020

Uh oh!

openshift-ci-robot commented Nov 3, 2020

Uh oh!

openshift-bot commented Nov 4, 2020

Uh oh!

openshift-ci-robot commented Nov 4, 2020

Uh oh!

openshift-bot commented Nov 5, 2020

Uh oh!

openshift-ci-robot commented Nov 5, 2020

Uh oh!

openshift-bot commented Nov 6, 2020

Uh oh!

openshift-ci-robot commented Nov 6, 2020

Uh oh!

openshift-bot commented Nov 7, 2020

Uh oh!

openshift-ci-robot commented Nov 7, 2020

Uh oh!

openshift-bot commented Nov 8, 2020

Uh oh!

openshift-ci-robot commented Nov 8, 2020

Uh oh!

openshift-bot commented Nov 9, 2020

Uh oh!

openshift-ci-robot commented Nov 9, 2020

Uh oh!

openshift-bot commented Nov 10, 2020

Uh oh!

openshift-ci-robot commented Nov 10, 2020

Uh oh!

awgreene commented Nov 10, 2020

Uh oh!

openshift-ci-robot commented Nov 10, 2020

Uh oh!

jianzhangbjz commented Nov 11, 2020