Bug 1905599: Preserve original .status.lastUpdateTime in copied CSVs.

[benluddy]

Currently, CSVs are mirrored into the namespaces that are watched by
the operator they represent. At the moment a copied CSV is updated,
its .status.lastUpdateTime field is set to the current time, rather
than using the same timestamp that appears on the original CSV's
status. As the size of a cluster grows, it becomes increasingly
unlikely that these two timestamps will have the same value. This
means that there's almost always a non-empty diff between the original
and any given copy, thereby triggering an update to the copy even if
nothing else has changed in the original.

[openshift-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[dinhxuanvu]

I think this is a reasonable stop-gap solution for the copied CSV issue.

[dinhxuanvu]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[exdx]

/lgtm
/retest

[openshift-ci-robot]

@benluddy: This pull request references Bugzilla bug 1881504, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1881504: Preserve original .status.lastUpdateTime in copied CSVs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@benluddy: This pull request references Bugzilla bug 1905599, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1905599: Preserve original .status.lastUpdateTime in copied CSVs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ecordell]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@ecordell: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[benluddy]

Patch for unrelated test flake is up: #1896.

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[benluddy]

/retest

[ecordell]

/retest

[openshift-ci-robot]

@benluddy: All pull requests linked via external trackers have merged:

• operator-framework/operator-lifecycle-manager#1892

Bugzilla bug 1905599 has been moved to the MODIFIED state.

In response to this:

Bug 1905599: Preserve original .status.lastUpdateTime in copied CSVs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@ecordell: #1892 failed to apply on top of branch "release-4.6":

Applying: Preserve original .status.lastUpdateTime in copied CSVs.
Using index info to reconstruct a base tree...
M	pkg/controller/operators/olm/operatorgroup.go
M	test/e2e/csv_e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/csv_e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/csv_e2e_test.go
Auto-merging pkg/controller/operators/olm/operatorgroup.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Preserve original .status.lastUpdateTime in copied CSVs.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.