Skip to content

Bug 1906134: Don't create OperatorConditions for copied CSVs #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Bug 1906134: Don't create OperatorConditions for copied CSVs #1899

merged 1 commit into from
Dec 11, 2020

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Dec 9, 2020

Problem: OLM is currently creating an OperatorCondition for copied CSVs.
As a result, OLM is reporting that the deployments defined in the copied
CSVs cannot be found.

Solution: OLM should not be creating OperatorCondtions for copied CSVs.
Update the OperatorConditionGenerator Reconciler to include predicate
functions that exclude copied CSVs.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@awgreene awgreene changed the title Don't create OperatorConditions for copied CSVs Bug 1906134: Don't create OperatorConditions for copied CSVs Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 9, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1906134, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1906134: Don't create OperatorConditions for copied CSVs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 9, 2020
benluddy
benluddy reviewed Dec 9, 2020
View reviewed changes
@awgreene
Copy link
Member Author

awgreene commented Dec 9, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1906134, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

awgreene commented Dec 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 9, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1906134, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene awgreene force-pushed the fix-operatorcondition-generation branch from 3401c15 to 09f29e1 Compare December 9, 2020 22:07
@awgreene
Copy link
Member Author

awgreene commented Dec 9, 2020

/retest

@kevinrizza
Copy link
Member

Tests?

@awgreene
Copy link
Member Author

Tests?

I can create a test that ensures an OpeneratorCondition wasn't created for a Copied CSV over x seconds but there is not a way to distinguish that the controller simply hasn't reconciled the Copied CSV yet.

@awgreene awgreene force-pushed the fix-operatorcondition-generation branch from 09f29e1 to e8f8b2d Compare December 10, 2020 13:57
@awgreene
Don't create OperatorConditions for copied CSVs
ff50a2a 
Problem: OLM is currently creating an OperatorCondition for copied CSVs.
As a result, OLM is reporting that the deployments defined in the copied
CSVs cannot be found.

Solution: OLM should not be creating OperatorCondtions for copied CSVs.
Update the OperatorConditionGenerator Reconciler to include predicate
functions that exclude copied CSVs.
@awgreene awgreene force-pushed the fix-operatorcondition-generation branch from e8f8b2d to ff50a2a Compare December 10, 2020 13:58
@awgreene
Copy link
Member Author

@kevinrizza I added the test described above which at least sounds an alarm if a Copied CSV is reconciled.

@kevinrizza
Copy link
Member

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@awgreene
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@awgreene
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2db452e into operator-framework:master Dec 11, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: All pull requests linked via external trackers have merged:

Bugzilla bug 1906134 has been moved to the MODIFIED state.

In response to this:

Bug 1906134: Don't create OperatorConditions for copied CSVs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy benluddy left review comments

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awgreene @openshift-ci-robot @kevinrizza @openshift-bot @benluddy @openshift-merge-robot