Skip to content

Add joelanford to OWNERS as reviewer #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add joelanford to OWNERS as reviewer #1948

merged 1 commit into from
Jan 11, 2021

Conversation

joelanford
Copy link
Member

Description of the change:
Add @joelanford to OWNERS as a reviewer.

Motivation for the change:
New team member :)

@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2021

@joelanford: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 30d69af link /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale njhale added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 11, 2021
@njhale
Copy link
Member

njhale commented Jan 11, 2021

/approve
/lgtm

Manually merging this since it doesn't affect OLM or tests.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@njhale njhale merged commit 4a9d02b into operator-framework:master Jan 11, 2021
@joelanford joelanford deleted the joelanford-reviewer branch January 11, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@awgreene awgreene Awaiting requested review from awgreene

Assignees

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelanford @njhale @openshift-ci-robot