Bug 1932626: Gracefully handle service unavailable errors from kube-apiserver #2024
Conversation
Signed-off-by: Joe Lanford <[email protected]>
openshift-ci-robot
added
the
do-not-merge/work-in-progress
| } | ||
| } | ||
|
|
||
| logger.Info("couldn't find GVK in api discovery") | ||
| return olmErrors.GroupVersionKindNotFoundError{group, version, kind} | ||
| return false, nil |
There was a problem hiding this comment.
I could not find any usage of isGVKRegistered where the actual content of the error was used, so I changed the function signature to separate the found/not found question from any errors that may have occurred trying to arrive at the answer.
If necessary, any caller of isGVKRegistered could trivially re-construct the previous behavior with:
func (a *Operator) oldIsGVKRegistered(group, version, kind string) error {
ok, err := a.isGVKRegistered(group, version, kind)
if err != nil {
return err
}
if !ok {
return olmErrors.GroupVersionKindNotFoundError{group, version, kind}
}
return nil
}
joelanford
force-pushed
the
fix/upgrade-alert
branch
from
fd4583a to
6537583
Compare
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
fix/upgrade-alert
branch
from
6537583 to
41e5126
Compare
joelanford
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@joelanford: This pull request references Bugzilla bug 1932626, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
1 similar comment
|
/retest |
|
This is still blocking us landing the "no alerts during upgrades" test: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25904/pull-ci-openshift-origin-master-e2e-gcp-upgrade/1369043944154861568 |
|
/retest |
|
/approve |
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, dinhxuanvu, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@joelanford: All pull requests linked via external trackers have merged: Bugzilla bug 1932626 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Joe Lanford [email protected]
Description of the change:
This PR changes the CSV install status update logic to avoid failing a CSV when there are there are transient errors connecting to the API server.
Motivation for the change:
OLM should not fire alerts during cluster upgrades when there are expected transient control plane connection issues.
Reviewer Checklist
/docs