Bug 1932182: Support jittering relatively small resync intervals. #2025
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
benluddy
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@benluddy: This pull request references Bugzilla bug 1932182, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
There was a problem hiding this comment.
Nice, I think this will definitely help with those CPU spikes.
I'm wondering if there is anything on the e2e or performance side we can add tests for to ensure that OLM performance is adequate (I think we may have even discussed this at one point). Not for this PR, but I think there are projects that do something like utilization-based profiling tests to ensure that these types of regressions don't occur. We tried adding resource limits to the OLM pods themselves but those didn't really work as intended
The previous jitter computation truncated intervals shorter than around 1 minute to 0. Intervals that short are atypical for resyncs, but still need to jitter to a reasonable value to avoid hot resync loops. Signed-off-by: Ben Luddy <[email protected]>
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@benluddy: This pull request references Bugzilla bug 1932182, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest |
|
@benluddy: once the present PR merges, I will cherry-pick it on top of relerase-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
D'oh! /cherry-pick release-4.7 |
|
@benluddy: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1932182 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@benluddy: new pull request created: #2041 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The previous jitter computation truncated intervals shorter than
around 1 minute to 0. Intervals that short are atypical for resyncs,
but still need to jitter to a reasonable value to avoid hot resync
loops.