Bug 1935909: Allow non-CSV-owned ServiceAccounts to satisfy CSV requirements. #2029
Conversation
openshift-ci-robot
added
the
approved
benluddy
force-pushed
the
sa-present-when-owned-by-non-csv
branch
from
4af5d80 to
b81e7ce
Compare
benluddy
force-pushed
the
sa-present-when-owned-by-non-csv
branch
from
b81e7ce to
0b40f54
Compare
|
/test e2e-aws-console-olm This test failure should now be resolved by openshift/console#8289. |
benluddy
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@benluddy: This pull request references Bugzilla bug 1935909, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.7 |
|
@benluddy: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/lgtm cancel @benluddy said he was going to add some e2e tests. |
benluddy
force-pushed
the
sa-present-when-owned-by-non-csv
branch
2 times, most recently
from
1014561 to
7a62dd1
Compare
The existing check, intended to prevent a race condition that could occur during CSV upgrades, marks a ServiceAccount as NotPresent when it has at least one owner but is not owned by the current CSV. It's expected for the ServiceAccount "default" not to be have an ownerreference to a CSV, so the check can be relaxed to only consider owners of kind ClusterServiceVersion. This also combines two ServiceAccount checks that were independently added to address the same race condition into a single check. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
sa-present-when-owned-by-non-csv
branch
from
7a62dd1 to
b375c4e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1935909 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@benluddy: new pull request created: #2034 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The existing check, intended to prevent a race condition that could
occur during CSV upgrades, marks a ServiceAccount as NotPresent when
it has at least one owner but is not owned by the current CSV. It's
expected for the ServiceAccount "default" not to be have an
ownerreference to a CSV, so the check can be relaxed to only consider
owners of kind ClusterServiceVersion.
This also combines two ServiceAccount checks that were independently
added to address the same race condition into a single check.