Bump the remaining images to Go 1.16 #2060
Conversation
| @@ -1,6 +1,7 @@ | |||
| # Dockerfile to bootstrap build and test in openshift-ci | |||
|
|
|||
| FROM openshift/origin-release:golang-1.15 | |||
| # TODO: do we need to use quay due to dockerhub rate limiting? | |||
| FROM openshift/origin-release:golang-1.16 | |||
There was a problem hiding this comment.
A quick note on this:
- No changes made to the build root Dockerfile will propagate to tests until it's been merged to master first, so we won't get any CI feedback from this, which should be fine but something to call out.
- We may want to avoid using an image hosted on docker.io due to potential flakes from rate limitations.
|
/retest |
|
/lgtm |
|
Can we update the upstream dockerfile to use 1.16 as well? |
timflannagan
force-pushed
the
go-1.16-bump
branch
from
7ca4a60 to
2cf08d2
Compare
|
@kevinrizza It looks like I had that changed locally, but didn't push those changes. Updated to include that upstream dockerfile. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Need to wait for #2064 to land before CI is back to green. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-gcp |
|
@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
The recent ART/CI Dockerfile(s) sync updated the repository to build and run e2e tests against Go 1.16, but the rest of the repository, namely the upstream images and the unit tests, still need to be manually bumped.
Motivation for the change:
Reviewer Checklist
/docs