Skip to content

Bump k8s dependencies to v0.20.4 #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

@timflannagan timflannagan commented Apr 1, 2021

Description of the change:
Avoid pinning against an untagged version of the k8s.io/apiserver
dependency, which contains the webhook authorization panic fix.

Instead, pin against the v0.20.4 tag, which contains that same upstream
fix.

Bump the remaining k8s.io/* dependencies to that v0.20.4 version

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@timflannagan timflannagan force-pushed the update-k8s-dependencies branch 2 times, most recently from f4b82cf to f51939b Compare April 1, 2021 20:44
@joelanford
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@timflannagan
Copy link
Member Author

/retest

Avoid pinning against an untagged version of the k8s.io/apiserver
dependency, which contains the wehbook authorization panic fix.

Instead, pin against the v0.20.4 tag, which contains that same upstream
fix.

Bump the remaining k8s.io/* dependencies to that v0.20.4 version

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the update-k8s-dependencies branch from f51939b to c7f4fcf Compare April 7, 2021 16:55
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2021

@timflannagan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade c7f4fcf link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy
Copy link
Contributor

benluddy commented Apr 8, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit edc5c88 into operator-framework:master Apr 8, 2021
@timflannagan timflannagan deleted the update-k8s-dependencies branch April 8, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants