Give more precise reasons for Subscriptions with no candidates. #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Subscription specifies certain criteria for selecting operators from catalogs. The granularity of the Subscription criteria is, from least to most specific: catalog, package, channel, startingCSV (if applicable). If a user creates a Subscription and its criteria does not match a single operator, the failure message now indicates the highest level of granularity that excludes all available operators. For example, if a Subscription specifies a package name that doesn't exist in the referenced, catalog, the specified package name will appear in the failure text. Signed-off-by: Ben Luddy <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@benluddy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
exdx
reviewed
Apr 8, 2021
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Subscription specifies certain criteria for selecting operators from
catalogs. The granularity of the Subscription criteria is, from least
to most specific: catalog, package, channel, startingCSV (if
applicable). If a user creates a Subscription and its criteria does
not match a single operator, the failure message now indicates the
highest level of granularity that excludes all available
operators. For example, if a Subscription specifies a package name
that doesn't exist in the referenced, catalog, the specified package
name will appear in the failure text.