Skip to content

Remove the root list of YAML manifests stored in the manifests directory #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Partially fixes #2130

Remove the root list of YAML manifests stored in manifests/

The root manifest directory was needed by the openshift cluster-version-operator (CVO) to deploy OLM in OCP cluster
environments. During the 4.8 release, the operator-framework/operator-lifecycle-manager repository was decoupled from the OCP release cadence, and a downstream repository was created in the openshift organization. As a result of this effort, this list of manifests is no longer needed and instead will live in the downstream repository.

@openshift-ci openshift-ci bot requested review from anik120 and ankitathomas May 10, 2021 18:56
The root manifest directory was needed by the openshift
cluster-version-operator (CVO) to deploy OLM in OCP cluster
environments. During the 4.8 release, the
operator-framework/operator-lifecycle-manager was decoupled from the OCP
release cadence, and a downstream repository was created in the
openshift organization. As a result of this effort, these list of
manifests are no longer needed and instead will live in the downstream
repository.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the remove-root-manifests branch from 704031d to 608bbfa Compare May 10, 2021 18:57
@benluddy
Copy link
Contributor

#2091

@benluddy
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1999e5e into operator-framework:master May 11, 2021
timflannagan added a commit to timflannagan/operator-lifecycle-manager that referenced this pull request May 11, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.
timflannagan added a commit to timflannagan/operator-lifecycle-manager that referenced this pull request May 11, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>
timflannagan added a commit to timflannagan/operator-lifecycle-manager that referenced this pull request May 11, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>
timflannagan added a commit to timflannagan/operator-lifecycle-manager that referenced this pull request May 11, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>
timflannagan added a commit to timflannagan/operator-lifecycle-manager that referenced this pull request May 11, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>
fantapsody pushed a commit to fantapsody/operator-lifecycle-manager that referenced this pull request May 24, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>
benluddy pushed a commit to benluddy/operator-framework-olm that referenced this pull request Jul 1, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework/operator-lifecycle-manager#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 5c26436abd8e3e95d61fda216de5d5197c05e8f3
openshift-merge-robot pushed a commit to openshift/operator-framework-olm that referenced this pull request Jul 14, 2021
- Additional work to decouple the upstream repository from OCP after operator-framework/operator-lifecycle-manager#2153 landed.
- Removes the OCP helm chart templates and the rendered manifests.

Signed-off-by: timflannagan <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 5c26436abd8e3e95d61fda216de5d5197c05e8f3
@timflannagan timflannagan deleted the remove-root-manifests branch October 13, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the root manifests directory and OCP/downstream helm charts
4 participants