-
Notifications
You must be signed in to change notification settings - Fork 562
.github/workflows: Separate out the e2e jobs into workflows #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: Separate out the e2e jobs into workflows #2158
Conversation
41826b5
to
a6b5dd3
Compare
@exdx This is probably a good time to revisit how we're naming these workflow/jobs instead of that other PR I posted last week. I think removing the upstream-* prefix from anything is a step in the right direction - any opinion on naming conventions, besides that? |
This looks great @timflannagan. The other thing I'd like to change is the duplicate name as I brought up in the prior PR, things like |
fc1d386
to
367e2b6
Compare
@exdx Done -- updated all of the workflow names to have a ci prefixed name. I don't have a great replacement name for that build action yet as there should be an issue tracking the need to also run that container image vs. just checking if we're successfully able to build it. |
367e2b6
to
1576623
Compare
/hold cancel |
/rerun-all |
Update the .github/workflows/test-scripts.yml GH action workflow and move all the jobs listed there into separate workflows. This allows us to retest a single workflow at a time as a workaround to GH not allowing you to retest individual jobs in a workflow. Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
1acf98d
to
8c941b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update the .github/workflows/test-scripts.yml GH action workflow and
move all the jobs listed there into separate workflows. This allows us
to retest a single workflow at a time as a workaround to GH not allowing
you to retest individual jobs in a workflow.
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc