Skip to content

[release-4.6] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2021
Merged

[release-4.6] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure #2189

merged 2 commits into from
Jun 9, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2107

/assign dinhxuanvu

dinhxuanvu added 2 commits June 8, 2021 11:52
@dinhxuanvu
fix(catalog): Reduce namespace resync in resolution failure
65c970d 
Every resolution error will trigger namespace resync up to 8 times.
This sometimes leads to excessive resync even though the problem
is persistent.

NotSatisfiable error from resolver is often terminal and require
further manual intervetion. This type of error usually won't get
resolved by retrying resolution. As a result, if catalog encounters
this error, it should move on and doesn't force immediate resync.
The resync will happen naturally later when the default resync is
triggered.

Signed-off-by: Vu Dinh <[email protected]>
@dinhxuanvu
Add unit test to verify resolver error handling for sync namespace
65ac3f0 
Signed-off-by: Vu Dinh <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 8, 2021
Merged
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@openshift-cherrypick-robot: Bugzilla bug 1951657 has been cloned as Bugzilla bug 1969412. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure

In response to this:

[release-4.6] [release-4.7] Bug 1951657: fix(catalog): Reduce namespace resync in resolution failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu dinhxuanvu changed the title [release-4.6] [release-4.7] Bug 1951657: fix(catalog): Reduce namespace resync in resolution failure [release-4.6] Bug 1951657: fix(catalog): Reduce namespace resync in resolution failure Jun 8, 2021
@openshift-ci openshift-ci bot changed the title [release-4.6] Bug 1951657: fix(catalog): Reduce namespace resync in resolution failure [release-4.6] [release-4.7] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure Jun 8, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1969412, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1951657 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1951657 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

[release-4.6] [release-4.7] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 8, 2021
@dinhxuanvu dinhxuanvu changed the title [release-4.6] [release-4.7] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure [release-4.6] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure Jun 8, 2021
@benluddy
Copy link
Contributor

benluddy commented Jun 8, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit b31c4ba into operator-framework:release-4.6 Jun 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1969412 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1969412: fix(catalog): Reduce namespace resync in resolution failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@joelanford joelanford

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @benluddy @joelanford @openshift-bot @ecordell @dinhxuanvu @openshift-merge-robot