Skip to content

Fixed CSV deployments label field doc #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ppatierno
Copy link
Contributor

This PR fixes a wrong labels field mentioned in the documentation for setting custom labels on CSV deployments, when the right name is label as defined in the code.

@openshift-ci openshift-ci bot requested review from dinhxuanvu and njhale June 9, 2021 12:17
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

Hi @ppatierno. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2021
@@ -323,7 +323,7 @@ Here’s a full example:
spec:
deployments:
- name: example-operator
labels:
label:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

$ oc explain clusterserviceversions.spec.install.spec.deployments
KIND:     ClusterServiceVersion
VERSION:  operators.coreos.com/v1alpha1

RESOURCE: deployments <[]Object>

DESCRIPTION:

     StrategyDeploymentSpec contains the name, spec and labels for the
     deployment ALM should create

FIELDS:
   label	<map[string]string>
     Set is a map of label:value. It implements Labels.

   name	<string> -required-

   spec	<Object> -required-
     DeploymentSpec is the specification of the desired behavior of the
     Deployment.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@timflannagan
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2021
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@anik120 anik120 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: anik120, ppatierno

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 20ded32 into operator-framework:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants