-
Notifications
You must be signed in to change notification settings - Fork 562
Fixed CSV deployments label field doc #2198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed CSV deployments label field doc #2198
Conversation
Signed-off-by: Paolo Patierno <[email protected]>
Hi @ppatierno. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -323,7 +323,7 @@ Here’s a full example: | |||
spec: | |||
deployments: | |||
- name: example-operator | |||
labels: | |||
label: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
$ oc explain clusterserviceversions.spec.install.spec.deployments
KIND: ClusterServiceVersion
VERSION: operators.coreos.com/v1alpha1
RESOURCE: deployments <[]Object>
DESCRIPTION:
StrategyDeploymentSpec contains the name, spec and labels for the
deployment ALM should create
FIELDS:
label <map[string]string>
Set is a map of label:value. It implements Labels.
name <string> -required-
spec <Object> -required-
DeploymentSpec is the specification of the desired behavior of the
Deployment.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: anik120, ppatierno The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes a wrong
labels
field mentioned in the documentation for setting custom labels on CSV deployments, when the right name islabel
as defined in the code.