[release-4.7] Bug 1972075: Add OperatorCondition status sync and update operator upgradeable check #2206

dinhxuanvu · 2021-06-15T08:19:45Z

Description of the change:

OperatorCondition controller will update its status to reflect the
changes on its spec regarding the operator conditions that are reported
by the operators themselves. In turn, operators can read the status
to confirm if OLM has processed the spec changes.

OLM will not take actions on upgradeable condition if the status is
stale using ObservedGeneration and Generation check.

Signed-off-by: Vu Dinh [email protected]

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /doc
Commit messages sensible and descriptive

OperatorCondition controller will update its status to refect the changes on its spec regarding the operator conditions that are reported by the operators themselves. In turn, operators can read the status to confirm if OLM has processed the spec changes. OLM will not take actions on upgradeable condition if the status is stale using ObservedGeneration and Generation check. Signed-off-by: Vu Dinh <[email protected]>

1. Operator can create/update/patch OperatorCondition but not its status. 2. Update the e2e test case to update OperatorCondition's spec directly instead of its status Signed-off-by: Vu Dinh <[email protected]>

openshift-ci · 2021-06-15T08:19:47Z

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add OperatorCondition status sync and update operator upgradeable check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:20:01Z

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] Add OperatorCondition status sync and update operator upgradeable check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:22:58Z

@dinhxuanvu: This pull request references Bugzilla bug 1972075, which is invalid:

expected dependent Bugzilla bug 1927340 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1972075: [release-4.7] Add OperatorCondition status sync and update operator upgradeable check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2021-06-15T15:01:11Z

/retest

dinhxuanvu · 2021-06-15T17:27:08Z

/retest

dinhxuanvu · 2021-06-16T21:36:50Z

/retest

dinhxuanvu · 2021-06-17T06:23:39Z

/retest

dinhxuanvu · 2021-06-17T14:56:13Z

/retest

dinhxuanvu · 2021-06-18T16:11:01Z

/retest

dinhxuanvu · 2021-06-18T20:09:02Z

/retest

dinhxuanvu · 2021-06-28T16:16:50Z

/retest

1. Update codegen to generate operatorv2 client code 2. Vendor operator-framework/api 0.9.0 3. Adopt the new changes on OperatorCondition API from api repo. 4. Update OperatorCondition v2 references across the codebase 5. Update e2e test case for OperatorCondition Signed-off-by: Vu Dinh <[email protected]>

timflannagan · 2021-06-28T22:33:52Z

/lgtm

dinhxuanvu · 2021-06-28T22:35:09Z

/bugzilla refresh

openshift-ci · 2021-06-28T22:35:17Z

@dinhxuanvu: This pull request references Bugzilla bug 1972075, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1927340 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1927340 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-28T22:35:18Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@dinhxuanvu: This pull request references Bugzilla bug 1972075, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.7.z) matches configured target release for branch (4.7.z)

bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

dependent bug Bugzilla bug 1927340 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))

dependent Bugzilla bug 1927340 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0

bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2021-06-28T23:38:23Z

/approve

openshift-ci · 2021-06-28T23:38:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-06-30T20:59:34Z

@dinhxuanvu: All pull requests linked via external trackers have merged:

operator-framework/operator-lifecycle-manager#2206

Bugzilla bug 1972075 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1972075: Add OperatorCondition status sync and update operator upgradeable check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu added 2 commits June 14, 2021 12:46

Update OperatorCondition Role and e2e test case

86eda22

1. Operator can create/update/patch OperatorCondition but not its status. 2. Update the e2e test case to update OperatorCondition's spec directly instead of its status Signed-off-by: Vu Dinh <[email protected]>

dinhxuanvu requested review from ecordell and awgreene June 15, 2021 08:19

openshift-ci bot requested review from anik120 and benluddy June 15, 2021 08:19

dinhxuanvu changed the title ~~Add OperatorCondition status sync and update operator upgradeable check~~ [release-4.7] Add OperatorCondition status sync and update operator upgradeable check Jun 15, 2021

dinhxuanvu changed the title ~~[release-4.7] Add OperatorCondition status sync and update operator upgradeable check~~ Bug 1972075: [release-4.7] Add OperatorCondition status sync and update operator upgradeable check Jun 15, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2021

dinhxuanvu changed the title ~~Bug 1972075: [release-4.7] Add OperatorCondition status sync and update operator upgradeable check~~ [release-4.7] Bug 1972075: Add OperatorCondition status sync and update operator upgradeable check Jun 15, 2021

dinhxuanvu force-pushed the opcon-gen-4.7 branch from d3a4ea3 to 97c7bdc Compare June 28, 2021 22:32

openshift-ci bot assigned timflannagan Jun 28, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 28, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 30, 2021

openshift-merge-robot merged commit a5f086a into operator-framework:release-4.7 Jun 30, 2021

wking mentioned this pull request Aug 3, 2021

ci-operator/config/openshift/release: Bump oldest-supported-z-rollback to 4.7.21 and 4.8.2 openshift/release#20847

Merged

[release-4.7] Bug 1972075: Add OperatorCondition status sync and update operator upgradeable check #2206

[release-4.7] Bug 1972075: Add OperatorCondition status sync and update operator upgradeable check #2206

Uh oh!

Conversation

dinhxuanvu commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

dinhxuanvu commented Jun 15, 2021

Uh oh!

dinhxuanvu commented Jun 15, 2021

Uh oh!

dinhxuanvu commented Jun 16, 2021

Uh oh!

dinhxuanvu commented Jun 17, 2021

Uh oh!

dinhxuanvu commented Jun 17, 2021

Uh oh!

dinhxuanvu commented Jun 18, 2021

Uh oh!

dinhxuanvu commented Jun 18, 2021

Uh oh!

dinhxuanvu commented Jun 28, 2021

Uh oh!

timflannagan commented Jun 28, 2021

Uh oh!

dinhxuanvu commented Jun 28, 2021

Uh oh!

openshift-ci bot commented Jun 28, 2021

Uh oh!

openshift-ci bot commented Jun 28, 2021

Uh oh!

kevinrizza commented Jun 28, 2021

Uh oh!

openshift-ci bot commented Jun 28, 2021

Uh oh!

openshift-ci bot commented Jun 30, 2021

Uh oh!

Uh oh!