[release-4.6] Bug 1975456: Handle invalid label during resource cleanup #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 2 commits into operator-framework:release-4.6 from dinhxuanvu:invalid-label-selector

Jun 23, 2021

Member

dinhxuanvu commented Jun 18, 2021

Invalid label due to too long CSV name will lead to label selector
malfunction as it returns an empty selector that matches everything.
As a result, some unrelated resources are garbaged-collected when OLM
is doing some resource cleanup during uninstallation. This fix will
use SelectorFromValidatedSet instead of SelectorFromSet to let the
server rejects invalid label sets instead of using am empty Selector.

Signed-off-by: Vu Dinh [email protected]

Description of the change:

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /doc
Commit messages sensible and descriptive


          Handle invalid label during resource cleanup

ad5171a

Invalid label due to too long CSV name will lead to label selector
malfunction as it returns an empty selector that matches everything.
As a result, some unrelated resources are garbaged-collected when OLM
is doing some resource cleanup during uninstallation. This fix will
use SelectorFromValidatedSet instead of SelectorFromSet to let the
server rejects invalid label sets instead of using am empty Selector.

Signed-off-by: Vu Dinh <[email protected]>

openshift-ci bot commented Jun 18, 2021

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Handle invalid label during resource cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from awgreene and benluddy

June 18, 2021 14:43

dinhxuanvu changed the title ~~Handle invalid label during resource cleanup~~ [release-4.6] Handle invalid label during resource cleanup

openshift-ci bot commented Jun 18, 2021

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] Handle invalid label during resource cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member Author

dinhxuanvu commented Jun 18, 2021

/retest

Contributor

benluddy commented Jun 18, 2021

/approve

openshift-ci bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label


          Add unit test to verify non-empty selector from CSVOwnerSelector

5662bc2

The CSVOwnerSelector should never return an empty selector (which
is equavalent of Everything()).

Signed-off-by: Vu Dinh <[email protected]>

Member

njhale commented Jun 18, 2021

/lgtm

openshift-ci bot assigned njhale

openshift-ci bot added the lgtm label

Contributor

openshift-bot commented Jun 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments

Contributor

openshift-bot commented Jun 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

dinhxuanvu changed the title ~~[release-4.6] Handle invalid label during resource cleanup~~ [release-4.6] Bug 1975456: Handle invalid label during resource cleanup

openshift-ci bot commented Jun 23, 2021

@dinhxuanvu: This pull request references Bugzilla bug 1975456, which is invalid:

expected dependent Bugzilla bug 1975453 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1975456: Handle invalid label during resource cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-urgent bugzilla/invalid-bug labels

Member Author

dinhxuanvu commented Jun 23, 2021

/bugzilla refresh

openshift-ci bot added bugzilla/valid-bug and removed bugzilla/invalid-bug labels

openshift-ci bot commented Jun 23, 2021

@dinhxuanvu: This pull request references Bugzilla bug 1975456, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1975453 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1975453 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot commented Jun 23, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: kasturinarra.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@dinhxuanvu: This pull request references Bugzilla bug 1975456, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.6.z) matches configured target release for branch (4.6.z)

bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

dependent bug Bugzilla bug 1975453 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))

dependent Bugzilla bug 1975453 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z

bug has dependents

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees added the cherry-pick-approved label

openshift-merge-robot merged commit 299fb8a into operator-framework:release-4.6

openshift-ci bot commented Jun 23, 2021

@dinhxuanvu: All pull requests linked via external trackers have merged:

operator-framework/operator-lifecycle-manager#2209

Bugzilla bug 1975456 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1975456: Handle invalid label during resource cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

anik120 added a commit to anik120/managed-cluster-config that referenced this pull request


          [MT-SRE 400] Stop creating openshift-logging namespace on OSD bootstrap

c8a3248

This PR removes:

1) deploy/bz1905684
2) deploy/osd-logging/unsupported/
3) SSS related to bz1905684 from hack/osd-stage.yaml

The workaround bz1905684(a cronjob) was possibly added because of an [olm
bug](operator-framework/operator-lifecycle-manager#2209 ) that has been fixed in 4.7.
The conjob no longer needs to be present on cluster, and therefore the
openshift-logging namespace does not need to get created on OSD bootstrap.

anik120 mentioned this pull request

[MT-SRE 400] Stop creating openshift-logging namespace on OSD bootstrap openshift/managed-cluster-config#1150

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/severity-urgent bugzilla/valid-bug cherry-pick-approved lgtm